chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_test.extjs - Issue 2782753002: Ensure only one instance of AutomationInternalCustomBindings for background page extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_test.extjs

Issue 2782753002: Ensure only one instance of AutomationInternalCustomBindings for background page extensions (Closed)

Patch Set: Rebase. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js ('k') | chrome/browser/resources/chromeos/chromevox/testing/mock_feedback.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_test.extjs

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_test.extjs b/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_test.extjs

index a84228bb29ec422f106b77333c9338d6f4c63713..a76ef137e73464b9bfc69e1c5ed6e8c943381721 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_test.extjs

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_test.extjs

@@ -85,8 +85,7 @@ TEST_F('PanelTest', 'LinkMenu', function() {

var mockFeedback = this.createMockFeedback();

this.runWithLoadedTree(this.linksDoc, function(root) {

var openMenus = new PanelCommand(PanelCommandType.OPEN_MENUS, 'role_link');

- mockFeedback.expectSpeech('apple')

- .call(openMenus.send.bind(openMenus))

+ mockFeedback.call(openMenus.send.bind(openMenus))

.expectSpeech('apple Link ', 'Menu item', ' 1 of 3 ', 'Link', 'Menu')

.call(this.fireMockEvent('ArrowLeft'))

.expectSpeech('Landmark', 'Menu', 'No items. ', 'Menu item', ' 1 of 1 ')

@@ -95,8 +94,7 @@ TEST_F('PanelTest', 'LinkMenu', function() {

.call(this.fireMockEvent('ArrowUp'))

.expectSpeech( 'banana Link ', 'Menu item', ' 3 of 3 ')

.call(this.fireMockEvent('Enter'))

- .expectSpeech( 'apple', 'Link', /data[\s\S]*window/)

- .expectSpeech('banana', 'Link')

+ .expectSpeech('banana', 'Link', /data.*window/)

.replay();

});