Correct UIApplicationState check for sad tab test.

ios/chrome/browser/tabs/tab.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/tabs/tab.h"
 
 #import <CoreLocation/CoreLocation.h>
 #import <UIKit/UIKit.h>
 
 #include <utility>
@@ skipping 181 matching lines @@
 // Tab.StateAtRendererTermination. Must be kept in sync with the UMA enum.
 enum class RendererTerminationTabState {
   // These two values are for when the app is in the foreground.
   FOREGROUND_TAB_FOREGROUND_APP = 0,
   BACKGROUND_TAB_FOREGROUND_APP,
   // These are for when the app is in the background.
   FOREGROUND_TAB_BACKGROUND_APP,
   BACKGROUND_TAB_BACKGROUND_APP,
   TERMINATION_TAB_STATE_COUNT
 };
+
+// Returns true if the application is in the background or inactive state.
+bool IsApplicationStateNotActive(UIApplicationState state) {
+  return (state == UIApplicationStateBackground ||
+          state == UIApplicationStateInactive);
+}
+
 }  // namespace
 
 @interface Tab ()<CRWWebStateObserver,
                   FindInPageControllerDelegate,
                   ReaderModeControllerDelegate> {
   TabModel* parentTabModel_;               // weak
   ios::ChromeBrowserState* browserState_;  // weak
 
   base::scoped_nsobject<OpenInController> openInController_;
   base::WeakNSProtocol<id<PassKitDialogProvider>> passKitDialogProvider_;
@@ skipping 1692 matching lines @@
     if (securityStyle == web::SECURITY_STYLE_AUTHENTICATION_BROKEN) {
       [fullScreenController_ disableFullScreen];
     }
   }
 
   [parentTabModel_ notifyTabChanged:self];
   [self updateFullscreenWithToolbarVisible:YES];
 }
 
 - (void)renderProcessGoneForWebState:(web::WebState*)webState {
+  UIApplicationState state = [UIApplication sharedApplication].applicationState;
+  BOOL applicationIsNotActive = IsApplicationStateNotActive(state);
   if (browserState_ && !browserState_->IsOffTheRecord()) {
     // Report the crash.
     GetApplicationContext()
         ->GetMetricsServicesManager()
         ->OnRendererProcessCrash();
 
     // Log the tab state for the termination.
     RendererTerminationTabState tab_state =
         visible_ ? RendererTerminationTabState::FOREGROUND_TAB_FOREGROUND_APP
                  : RendererTerminationTabState::BACKGROUND_TAB_FOREGROUND_APP;
-    if ([UIApplication sharedApplication].applicationState ==
-        UIApplicationStateBackground) {
+    if (applicationIsNotActive) {
       tab_state =
           visible_ ? RendererTerminationTabState::FOREGROUND_TAB_BACKGROUND_APP
                    : RendererTerminationTabState::BACKGROUND_TAB_BACKGROUND_APP;
     }
     UMA_HISTOGRAM_ENUMERATION(
         kRendererTerminationStateHistogram, static_cast<int>(tab_state),
         static_cast<int>(
             RendererTerminationTabState::TERMINATION_TAB_STATE_COUNT));
     if ([parentTabModel_ tabUsageRecorder])
       [parentTabModel_ tabUsageRecorder]->RendererTerminated(self, visible_);
   }
 
-  BOOL applicationIsBackgrounded =
-      [UIApplication sharedApplication].applicationState ==
-      UIApplicationStateBackground;
   if (visible_) {
-    if (!applicationIsBackgrounded) {
+    if (!applicationIsNotActive) {
       base::WeakNSObject<Tab> weakSelf(self);
       base::scoped_nsobject<SadTabView> sadTabView(
           [[SadTabView alloc] initWithReloadHandler:^{
             base::scoped_nsobject<Tab> strongSelf([weakSelf retain]);
 
             // |check_for_repost| is true because this is called from SadTab and
             // explicitly initiated by the user.
             [strongSelf navigationManager]->Reload(web::ReloadType::NORMAL,
                                                    true /* check_for_repost */);
           }]);
       base::scoped_nsobject<CRWContentView> contentView(
           [[CRWGenericContentView alloc] initWithView:sadTabView]);
       self.webState->ShowTransientContentView(contentView);
       [fullScreenController_ disableFullScreen];
     }
   } else {
     [self.webController requirePageReload];
   }
   // Returning to the app (after the renderer crashed in the background) and
   // having the page reload is much less confusing for the user.
   // Note: Given that the tab is visible, calling |requirePageReload| will not
   // work when the app becomes active because there is nothing to trigger
   // a view redisplay in that scenario.
-  requireReloadAfterBecomingActive_ = visible_ && applicationIsBackgrounded;
+  requireReloadAfterBecomingActive_ = visible_ && applicationIsNotActive;
   [self.dialogDelegate cancelDialogForTab:self];
 }
 
 - (void)webController:(CRWWebController*)webController
     didLoadPassKitObject:(NSData*)data {
   [self.passKitDialogProvider presentPassKitDialog:data];
 }
 
 #pragma mark - PrerenderDelegate
 
@@ skipping 118 matching lines @@
 
 - (TabModel*)parentTabModel {
   return parentTabModel_;
 }
 
 - (FormInputAccessoryViewController*)inputAccessoryViewController {
   return inputAccessoryViewController_.get();
 }
 
 @end