Correct UIApplicationState check for sad tab test.

ios/chrome/browser/tabs/tab.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/tabs/tab.h"
 
 #import <CoreLocation/CoreLocation.h>
 #import <UIKit/UIKit.h>
 
 #include <utility>
@@ skipping 1895 matching lines @@
   if (browserState_ && !browserState_->IsOffTheRecord()) {
     // Report the crash.
     GetApplicationContext()
         ->GetMetricsServicesManager()
         ->OnRendererProcessCrash();
 
     // Log the tab state for the termination.
     RendererTerminationTabState tab_state =
         visible_ ? RendererTerminationTabState::FOREGROUND_TAB_FOREGROUND_APP
                  : RendererTerminationTabState::BACKGROUND_TAB_FOREGROUND_APP;
-    if ([UIApplication sharedApplication].applicationState ==
-        UIApplicationStateBackground) {
+    if ([UIApplication sharedApplication].applicationState !=
+        UIApplicationStateActive) {
       tab_state =
           visible_ ? RendererTerminationTabState::FOREGROUND_TAB_BACKGROUND_APP
                    : RendererTerminationTabState::BACKGROUND_TAB_BACKGROUND_APP;
     }
     UMA_HISTOGRAM_ENUMERATION(
         kRendererTerminationStateHistogram, static_cast<int>(tab_state),
         static_cast<int>(
             RendererTerminationTabState::TERMINATION_TAB_STATE_COUNT));
     if ([parentTabModel_ tabUsageRecorder])
       [parentTabModel_ tabUsageRecorder]->RendererTerminated(self, visible_);
   }
 
   BOOL applicationIsBackgrounded =

[pkl (ping after 24h if needed), 2017/03/29 14:28:01]

nit: Can we rename this var to isNotActive or appIsNotActive?

[justincohen, 2017/03/29 15:23:37]

Done.

-      [UIApplication sharedApplication].applicationState ==
-      UIApplicationStateBackground;
+      [UIApplication sharedApplication].applicationState !=
+      UIApplicationStateActive;
   if (visible_) {
     if (!applicationIsBackgrounded) {
       base::WeakNSObject<Tab> weakSelf(self);
       base::scoped_nsobject<SadTabView> sadTabView(
           [[SadTabView alloc] initWithReloadHandler:^{
             base::scoped_nsobject<Tab> strongSelf([weakSelf retain]);
 
             // |check_for_repost| is true because this is called from SadTab and
             // explicitly initiated by the user.
             [strongSelf navigationManager]->Reload(web::ReloadType::NORMAL,
@@ skipping 144 matching lines @@
 
 - (TabModel*)parentTabModel {
   return parentTabModel_;
 }
 
 - (FormInputAccessoryViewController*)inputAccessoryViewController {
   return inputAccessoryViewController_.get();
 }
 
 @end