Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2782703002: Include the awaiter stack trace in the service protocol (Closed)

Created:
3 years, 8 months ago by Cutch
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Include the awaiter stack trace in the service protocol - [x] Include the (non-empty) awaiter stack trace in every `getStack` RPC. - [x] Append the causal stack trace to the final frame of the awaiter stack trace. - [x] Unit test for awaiter stack trace. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/d8555fb5a8a85a612b1455582589263dba5774a5

Patch Set 1 #

Total comments: 4

Patch Set 2 : rmacnak review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -14 lines) Patch
M runtime/observatory/lib/src/models/objects/frame.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/awaiter_async_stack_contents_test.dart View 1 chunk +73 lines, -0 lines 0 comments Download
M runtime/vm/debugger.h View 6 chunks +10 lines, -2 lines 0 comments Download
M runtime/vm/debugger.cc View 1 16 chunks +103 lines, -11 lines 0 comments Download
M runtime/vm/scopes.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/service.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M runtime/vm/service/service_dev.md View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Cutch
3 years, 8 months ago (2017-03-28 19:40:31 UTC) #3
rmacnak
lgtm https://codereview.chromium.org/2782703002/diff/1/runtime/vm/debugger.cc File runtime/vm/debugger.cc (right): https://codereview.chromium.org/2782703002/diff/1/runtime/vm/debugger.cc#newcode2045 runtime/vm/debugger.cc:2045: ActivationFrame* activation = new ActivationFrame(async_activation); new(zone) https://codereview.chromium.org/2782703002/diff/1/runtime/vm/debugger.cc#newcode2063 runtime/vm/debugger.cc:2063: ...
3 years, 8 months ago (2017-03-29 01:04:26 UTC) #4
Cutch
Committed patchset #2 (id:20001) manually as d8555fb5a8a85a612b1455582589263dba5774a5 (presubmit successful).
3 years, 8 months ago (2017-03-29 13:56:57 UTC) #6
Cutch
3 years, 8 months ago (2017-03-29 13:57:43 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/2782703002/diff/1/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

https://codereview.chromium.org/2782703002/diff/1/runtime/vm/debugger.cc#newc...
runtime/vm/debugger.cc:2045: ActivationFrame* activation = new
ActivationFrame(async_activation);
On 2017/03/29 01:04:26, rmacnak wrote:
> new(zone)

Done.

https://codereview.chromium.org/2782703002/diff/1/runtime/vm/debugger.cc#newc...
runtime/vm/debugger.cc:2063: break;
On 2017/03/29 01:04:26, rmacnak wrote:
> // Incomplete OutOfMemory/StackOverflow trace.

This can also be alignment related padding at the tail of the array.

Powered by Google App Engine
This is Rietveld 408576698