Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: components/offline_pages/core/offline_page_model_impl.cc

Issue 2782673002: [Offline pages] Removing obsolete TODOs as part of PE fixit (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/offline_page_model_impl.cc
diff --git a/components/offline_pages/core/offline_page_model_impl.cc b/components/offline_pages/core/offline_page_model_impl.cc
index 2e87035d1f69577f80997550ca96de221c845d67..5f4af98ed1b489f383fed151aa363816935f096a 100644
--- a/components/offline_pages/core/offline_page_model_impl.cc
+++ b/components/offline_pages/core/offline_page_model_impl.cc
@@ -572,7 +572,6 @@ const std::vector<int64_t> OfflinePageModelImpl::MaybeGetOfflineIdsForClientId(
std::vector<int64_t> results;
// We want only all pages, including those marked for deletion.
- // TODO(fgorski): actually use an index rather than linear scan.
for (const auto& id_page_pair : offline_pages_) {
if (id_page_pair.second.client_id == client_id)
results.push_back(id_page_pair.second.offline_id);
@@ -690,8 +689,6 @@ void OfflinePageModelImpl::OnCreateArchiveDone(
int64_t file_size) {
if (save_page_params.url != url) {
DVLOG(1) << "Saved URL does not match requested URL.";
- // TODO(fgorski): We have created an archive for a wrong URL. It should be
- // deleted from here, once archiver has the right functionality.
InformSavePageDone(callback, SavePageResult::ARCHIVE_CREATION_FAILED,
save_page_params.client_id, offline_id);
DeletePendingArchiver(archiver);
@@ -956,10 +953,6 @@ void OfflinePageModelImpl::OnRemoveOfflinePagesDone(
observer.OfflinePageDeleted(page.offline_id, page.client_id);
}
- // TODO(fgorski): React the FAILED_INITIALIZATION, FAILED_RESET here.
- // TODO(fgorski): We need a better callback interface for the Remove action on
- // the this class. Currently removing an item that does not exist is
- // considered a success, but not called out as such to the caller.
DeletePageResult delete_result;
if (result->store_state == StoreState::LOADED)
delete_result = DeletePageResult::SUCCESS;

Powered by Google App Engine
This is Rietveld 408576698