Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: components/offline_pages/core/background/save_page_request.cc

Issue 2782673002: [Offline pages] Removing obsolete TODOs as part of PE fixit (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/background/save_page_request.cc
diff --git a/components/offline_pages/core/background/save_page_request.cc b/components/offline_pages/core/background/save_page_request.cc
index 9b19dc4d429cad74f36178d480e7796d62e8cc37..e30a8edc4e92b74958cba8d146d9b6b845677c14 100644
--- a/components/offline_pages/core/background/save_page_request.cc
+++ b/components/offline_pages/core/background/save_page_request.cc
@@ -65,9 +65,6 @@ bool SavePageRequest::operator==(const SavePageRequest& other) const {
void SavePageRequest::MarkAttemptStarted(const base::Time& start_time) {
DCHECK_LE(activation_time_, start_time);
- // TODO(fgorski): As part of introducing policy in GetStatus, we can make a
- // check here to ensure we only start tasks in status pending, and bail out in
- // other cases.
last_attempt_time_ = start_time;
++started_attempt_count_;
state_ = RequestState::OFFLINING;

Powered by Google App Engine
This is Rietveld 408576698