chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc - Issue 2782673002: [Offline pages] Removing obsolete TODOs as part of PE fixit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc

Issue 2782673002: [Offline pages] Removing obsolete TODOs as part of PE fixit (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc ('k') | chrome/browser/android/offline_pages/request_coordinator_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc

diff --git a/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc b/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc

index 27948ae0aa02652fe93f6c0ba118d6737a6b37ca..d8560f1e05a4decd9683d68e844ed3399141b3f7 100644

--- a/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc

+++ b/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc

@@ -87,9 +87,6 @@ void OfflinePageMHTMLArchiver::GenerateMHTML(

return;

}

- // TODO(fgorski): Figure out if the actual URL can be different at

- // the end of MHTML generation. Perhaps we should pull it out after the MHTML

- // is generated.

GURL url(web_contents_->GetLastCommittedURL());

base::string16 title(web_contents_->GetTitle());

base::FilePath file_path(