Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results_unittest.py

Issue 2782653002: Revert of Fix testharness result parsing, make "Harness error" count as failure. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results_unittest.py
index 7169e19d05f4d650b7eaaa93c21ae2f4ec768dc1..2c78e0cc047abbde89aa09cb264c51fb609f58d2 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results_unittest.py
@@ -30,11 +30,6 @@
' PASS: foo bar \n'
'FAIL \n'
' Harness: the test ran to completion.'))
- self.assertFalse(testharness_results.is_all_pass_testharness_result(
- 'This is a testharness.js-based test.\n'
- 'Harness Error. harness_status.status = 1\n'
- 'PASS foo bar\n'
- 'Harness: the test ran to completion.'))
def test_is_testharness_output_positive_cases(self):
self.assertTrue(testharness_results.is_testharness_output(
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698