Issue 2782623002: Update corelib_strong/ and lib_strong/ status for new top-level inference failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2782623002: Update corelib_strong/ and lib_strong/ status for new top-level inference failures. (Closed)

Created:
3 years, 8 months ago by scheglov

Modified:
3 years, 8 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Update corelib_strong/ and lib_strong/ status for new top-level inference failures. TBR R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ec8e9f89262e7ec0078ed242d207336c01b794e8

Patch Set 1 #

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	tests/corelib_strong/corelib_strong.status	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	tests/lib_strong/lib_strong.status	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scheglov

Committed patchset #1 (id:1) manually as ec8e9f89262e7ec0078ed242d207336c01b794e8 (presubmit successful).

3 years, 8 months ago (2017-03-28 17:48:13 UTC) #3

Brian Wilkerson

lgtm Are the errors expected to be generated? If so, we should update the tests. ...

3 years, 8 months ago (2017-03-28 18:07:59 UTC) #4

scheglov

3 years, 8 months ago (2017-03-28 18:10:46 UTC) #5

Message was sent while issue was closed.

On 2017/03/28 18:07:59, Brian Wilkerson wrote:
> lgtm
> 
> Are the errors expected to be generated? If so, we should update the tests. If
> not, we should have an issue for the failures.

I think I can update most of the tests (will prepare CL for this soon).
But for some it is hard to say what was the intention of the author.
This will require an iteration with asking authors first.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages