ios/chrome/browser/ui/content_suggestions/BUILD.gn - Issue 2782613004: Add FaviconAttributesProvider to ContentSuggestions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/content_suggestions/BUILD.gn

Issue 2782613004: Add FaviconAttributesProvider to ContentSuggestions (Closed)

Patch Set: Cleanup Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/content_suggestions/BUILD.gn

diff --git a/ios/chrome/browser/ui/content_suggestions/BUILD.gn b/ios/chrome/browser/ui/content_suggestions/BUILD.gn

index 80fad69fabf3f50e71f9d3dbef3719b5555c7ee2..6a6b7f79b1047b9a6c9b458df1d6a751f8495204 100644

--- a/ios/chrome/browser/ui/content_suggestions/BUILD.gn

+++ b/ios/chrome/browser/ui/content_suggestions/BUILD.gn

@@ -19,6 +19,7 @@ source_set("content_suggestions") {

":resources",

"//base",

"//components/strings",

+ "//ios/chrome/browser/favicon",

lpromero 2017/03/29 13:32:07 I don't think the UI should know about favicons.

gambard 2017/03/30 08:07:11 Done.

"//ios/chrome/browser/ui/collection_view",

"//ios/chrome/browser/ui/content_suggestions/cells",

"//ios/chrome/browser/ui/content_suggestions/identifier",