Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3452)

Unified Diff: build/vs_toolchain.py

Issue 2782603002: Enable content shell crash integration test on Windows (Closed)
Patch Set: updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/win/BUILD.gn » ('j') | build/win/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/vs_toolchain.py
diff --git a/build/vs_toolchain.py b/build/vs_toolchain.py
index 243159d857c9dcf735f85d55f6e8bcb9cc2c902a..b04d32b89d8ed7fac0e07523f6fc373401a8f12c 100755
--- a/build/vs_toolchain.py
+++ b/build/vs_toolchain.py
@@ -304,28 +304,6 @@ def CopyDlls(target_dir, configuration, target_cpu):
if configuration == 'Debug':
_CopyRuntime(target_dir, runtime_dir, target_cpu, debug=True)
- _CopyDebugger(target_dir, target_cpu)
-
-
-def _CopyDebugger(target_dir, target_cpu):
- """Copy cdb.exe into the requested directory as needed.
-
- target_cpu is one of 'x86' or 'x64'.
-
- This is used for the GN build.
- """
- win_sdk_dir = SetEnvironmentAndGetSDKDir()
- if not win_sdk_dir:
- return
-
- debugger_files = (
- 'cdb.exe', 'dbgeng.dll', 'dbghelp.dll', 'dbgmodel.dll', 'dbgcore.dll')
-
- for debug_file in debugger_files:
- full_path = os.path.join(win_sdk_dir, 'Debuggers', target_cpu, debug_file)
- target_path = os.path.join(target_dir, debug_file)
- _CopyRuntimeImpl(target_path, full_path)
-
def _GetDesiredVsToolchainHashes():
"""Load a list of SHA1s corresponding to the toolchains that we want installed
« no previous file with comments | « no previous file | build/win/BUILD.gn » ('j') | build/win/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698