Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: content/shell/BUILD.gn

Issue 2782603002: Enable content shell crash integration test on Windows (Closed)
Patch Set: typo Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/BUILD.gn
diff --git a/content/shell/BUILD.gn b/content/shell/BUILD.gn
index 2f5c0aeca9fe9d90566491a351075c3412614570..061183bc2376e17947b61a972a6aff5b475e9a4d 100644
--- a/content/shell/BUILD.gn
+++ b/content/shell/BUILD.gn
@@ -793,7 +793,21 @@ group("content_shell_crash_test") {
]
}
if (is_win) {
- data_deps += [ ":content_shell_crash_service" ]
+ data_deps += [
+ ":content_shell_crash_service",
+ "//build/win/copy_cdb_to_output:copy_cdb_to_output",
Dirk Pranke 2017/03/30 18:28:23 Nit: GN style would be just "//build/win/copy_cdb_
+ ]
+
+ # TODO(GYP): These should be provided automatically through data_deps.
Dirk Pranke 2017/03/30 18:28:23 Are you sure these aren't automatically provided n
jochen (gone - plz use gerrit) 2017/03/31 08:47:02 I just copied this from the telemetry BUILD.gn fil
+ data += [ "$root_out_dir/content_shell.exe.pdb" ]
+ if (is_component_build) {
+ data += [
+ "$root_out_dir/base.dll.pdb",
+ "$root_out_dir/blink_platform.dll.pdb",
+ "$root_out_dir/blink_web.dll.pdb",
+ "$root_out_dir/content.dll.pdb",
+ ]
+ }
}
if (is_posix && !is_android) {
data_deps += [

Powered by Google App Engine
This is Rietveld 408576698