Enable content shell crash integration test on Windows

build/vs_toolchain.py

Index: build/vs_toolchain.py
diff --git a/build/vs_toolchain.py b/build/vs_toolchain.py
index 243159d857c9dcf735f85d55f6e8bcb9cc2c902a..f34439cb18fadde518faf692d6bc263cd6eaf845 100755
--- a/build/vs_toolchain.py
+++ b/build/vs_toolchain.py
@@ -304,28 +304,6 @@ def CopyDlls(target_dir, configuration, target_cpu):
   if configuration == 'Debug':
     _CopyRuntime(target_dir, runtime_dir, target_cpu, debug=True)
 
-  _CopyDebugger(target_dir, target_cpu)
-
-
-def _CopyDebugger(target_dir, target_cpu):
-  """Copy cdb.exe into the requested directory as needed.
-
-  target_cpu is one of 'x86' or 'x64'.
-
-  This is used for the GN build.
-  """
-  win_sdk_dir = SetEnvironmentAndGetSDKDir()
-  if not win_sdk_dir:
-    return
-
-  debugger_files = (
-        'cdb.exe', 'dbgeng.dll', 'dbghelp.dll', 'dbgmodel.dll', 'dbgcore.dll')
-
-  for debug_file in debugger_files:
-    full_path = os.path.join(win_sdk_dir, 'Debuggers', target_cpu, debug_file)
-    target_path = os.path.join(target_dir, debug_file)
-    _CopyRuntimeImpl(target_path, full_path)
-
 
 def _GetDesiredVsToolchainHashes():
   """Load a list of SHA1s corresponding to the toolchains that we want installed
@@ -393,8 +371,8 @@ def NormalizePath(path):
   return path
 
 
-def SetEnvironmentAndGetSDKDir():

[scottmg, 2017/03/29 23:17:39]

This is used from tools/win/setenv.py, can you update that script as well?

[jochen (gone - plz use gerrit), 2017/03/31 08:47:02]

I left this method in instead

-  """Gets location information about the current sdk (must have been
+def GetToolchainDir():
+  """Gets location information about the current toolchain (must have been
   previously updated by 'update'). This is used for the GN build."""
   runtime_dll_dirs = SetEnvironmentAndGetRuntimeDllDirs()
 
@@ -404,15 +382,6 @@ def SetEnvironmentAndGetSDKDir():
     if os.path.isdir(default_sdk_path):
       os.environ['WINDOWSSDKDIR'] = default_sdk_path
 
-  return NormalizePath(os.environ['WINDOWSSDKDIR'])
-
-
-def GetToolchainDir():
-  """Gets location information about the current toolchain (must have been
-  previously updated by 'update'). This is used for the GN build."""
-  runtime_dll_dirs = SetEnvironmentAndGetRuntimeDllDirs()
-  win_sdk_dir = SetEnvironmentAndGetSDKDir()
-
   print '''vs_path = "%s"
 sdk_path = "%s"
 vs_version = "%s"
@@ -420,7 +389,7 @@ wdk_dir = "%s"
 runtime_dirs = "%s"
 ''' % (
       NormalizePath(os.environ['GYP_MSVS_OVERRIDE_PATH']),
-      win_sdk_dir,
+      NormalizePath(os.environ['WINDOWSSDKDIR']),
       GetVisualStudioVersion(),
       NormalizePath(os.environ.get('WDK_DIR', '')),
       os.path.pathsep.join(runtime_dll_dirs or ['None']))