Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 2782583003: Extract the AST specific part of NoSuchMethodRegistry (Closed)

Created:
3 years, 8 months ago by Johnni Winther
Modified:
3 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extract the AST specific part of NoSuchMethodRegistry This is a step towards making NoSuchMethodRegistry reusable for K-elements. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/20ab9673c35ade5a39a4e594e1cebda6a8510db0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -63 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 6 chunks +6 lines, -20 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_helpers.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/no_such_method_registry.dart View 9 chunks +47 lines, -41 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 8 months ago (2017-03-28 14:26:14 UTC) #2
Emily Fortuna
lgtm
3 years, 8 months ago (2017-03-28 18:29:48 UTC) #3
Johnni Winther
3 years, 8 months ago (2017-03-29 10:09:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
20ab9673c35ade5a39a4e594e1cebda6a8510db0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698