Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: components/sync/engine/browser_thread_model_worker.h

Issue 2782573002: [Sync] Refactor ModelSafeWorker::DoWorkAndWaitUntilDone() to avoid code duplication. (Closed)
Patch Set: fix-test-error Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/engine/browser_thread_model_worker.h
diff --git a/components/sync/engine/browser_thread_model_worker.h b/components/sync/engine/browser_thread_model_worker.h
index 3a121f66f6601c32c7c9112a8f29c1c6284b9cbe..77cc8540b3d8a8da313ca512559c9b49f20c0eb5 100644
--- a/components/sync/engine/browser_thread_model_worker.h
+++ b/components/sync/engine/browser_thread_model_worker.h
@@ -8,8 +8,6 @@
#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "base/single_thread_task_runner.h"
-#include "components/sync/base/scoped_event_signal.h"
-#include "components/sync/base/syncer_error.h"
#include "components/sync/engine/model_safe_worker.h"
namespace syncer {
@@ -28,16 +26,11 @@ class BrowserThreadModelWorker : public ModelSafeWorker {
ModelSafeGroup GetModelSafeGroup() override;
bool IsOnModelThread() override;
- protected:
+ private:
~BrowserThreadModelWorker() override;
- SyncerError DoWorkAndWaitUntilDoneImpl(const WorkCallback& work) override;
-
- void CallDoWorkAndSignalTask(const WorkCallback& work,
- syncer::ScopedEventSignal scoped_event_signal,
- SyncerError* error);
+ void ScheduleWork(base::Closure work) override;
- private:
scoped_refptr<base::SingleThreadTaskRunner> runner_;
ModelSafeGroup group_;

Powered by Google App Engine
This is Rietveld 408576698