Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: components/sync/test/engine/fake_model_worker.cc

Issue 2782573002: [Sync] Refactor ModelSafeWorker::DoWorkAndWaitUntilDone() to avoid code duplication. (Closed)
Patch Set: self-review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/sync/test/engine/fake_model_worker.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/sync/test/engine/fake_model_worker.h" 5 #include "components/sync/test/engine/fake_model_worker.h"
6 6
7 #include "base/callback.h" 7 #include <utility>
8 8
9 namespace syncer { 9 namespace syncer {
10 10
11 FakeModelWorker::FakeModelWorker(ModelSafeGroup group) : group_(group) {} 11 FakeModelWorker::FakeModelWorker(ModelSafeGroup group) : group_(group) {}
12 12
13 FakeModelWorker::~FakeModelWorker() { 13 FakeModelWorker::~FakeModelWorker() {
14 // We may need to relax this is FakeModelWorker is used in a 14 // We may need to relax this is FakeModelWorker is used in a
15 // multi-threaded test; since ModelSafeWorkers are 15 // multi-threaded test; since ModelSafeWorkers are
16 // RefCountedThreadSafe, they could theoretically be destroyed from 16 // RefCountedThreadSafe, they could theoretically be destroyed from
17 // a different thread. 17 // a different thread.
18 DCHECK(thread_checker_.CalledOnValidThread()); 18 DCHECK(thread_checker_.CalledOnValidThread());
19 } 19 }
20 20
21 SyncerError FakeModelWorker::DoWorkAndWaitUntilDoneImpl( 21 void FakeModelWorker::ScheduleWork(base::OnceClosure work) {
22 const WorkCallback& work) {
23 DCHECK(thread_checker_.CalledOnValidThread()); 22 DCHECK(thread_checker_.CalledOnValidThread());
24 // Simply do the work on the current thread. 23 // Simply do the work on the current thread.
25 return work.Run(); 24 std::move(work).Run();
26 } 25 }
27 26
28 ModelSafeGroup FakeModelWorker::GetModelSafeGroup() { 27 ModelSafeGroup FakeModelWorker::GetModelSafeGroup() {
29 DCHECK(thread_checker_.CalledOnValidThread()); 28 DCHECK(thread_checker_.CalledOnValidThread());
30 return group_; 29 return group_;
31 } 30 }
32 31
33 bool FakeModelWorker::IsOnModelThread() { 32 bool FakeModelWorker::IsOnModelThread() {
34 return thread_checker_.CalledOnValidThread(); 33 return thread_checker_.CalledOnValidThread();
35 } 34 }
36 35
37 } // namespace syncer 36 } // namespace syncer
OLDNEW
« no previous file with comments | « components/sync/test/engine/fake_model_worker.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698