Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: components/translate/core/browser/translate_manager_unittest.cc

Issue 2782553004: Move TestingPrefService to use unique_ptr<Value> (Closed)
Patch Set: comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_manager_unittest.cc
diff --git a/components/translate/core/browser/translate_manager_unittest.cc b/components/translate/core/browser/translate_manager_unittest.cc
index fda38d798ab21257c32a8274876b62fa875d7958..77552ef0190481d07d35719caa37f92c3cc608b4 100644
--- a/components/translate/core/browser/translate_manager_unittest.cc
+++ b/components/translate/core/browser/translate_manager_unittest.cc
@@ -4,6 +4,8 @@
#include "components/translate/core/browser/translate_manager.h"
+#include <utility>
+
#include "base/json/json_reader.h"
#include "base/memory/ptr_util.h"
#include "base/run_loop.h"
@@ -172,7 +174,8 @@ class TranslateManagerTest : public ::testing::Test {
void PrepareULPTest(const char* ulp_json, bool turn_on_feature) {
PrepareTranslateManager();
std::unique_ptr<base::Value> profile(CreateProfileFromJSON(ulp_json));
- prefs_.SetUserPref(TranslatePrefs::kPrefLanguageProfile, profile.release());
+ prefs_.SetUserPref(TranslatePrefs::kPrefLanguageProfile,
+ std::move(profile));
if (turn_on_feature)
TurnOnTranslateByULP();
}

Powered by Google App Engine
This is Rietveld 408576698