Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: components/certificate_transparency/ct_policy_manager_unittest.cc

Issue 2782553004: Move TestingPrefService to use unique_ptr<Value> (Closed)
Patch Set: comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/certificate_transparency/ct_policy_manager_unittest.cc
diff --git a/components/certificate_transparency/ct_policy_manager_unittest.cc b/components/certificate_transparency/ct_policy_manager_unittest.cc
index 6abc261cbb5a601cd7b8e0e57bc4d13d407df92d..e535f98baa3526fca6cc5eac328dc385fda46460 100644
--- a/components/certificate_transparency/ct_policy_manager_unittest.cc
+++ b/components/certificate_transparency/ct_policy_manager_unittest.cc
@@ -20,12 +20,13 @@ namespace certificate_transparency {
namespace {
-base::ListValue* ListValueFromStrings(const std::vector<const char*>& strings) {
+std::unique_ptr<base::ListValue> ListValueFromStrings(
+ const std::vector<const char*>& strings) {
std::unique_ptr<base::ListValue> result(new base::ListValue);
for (auto* const str : strings) {
result->AppendString(str);
}
- return result.release();
+ return result;
}
class CTPolicyManagerTest : public ::testing::Test {
« no previous file with comments | « components/browser_sync/profile_sync_service_unittest.cc ('k') | components/cryptauth/cryptauth_device_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698