Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: components/browser_sync/profile_sync_service_unittest.cc

Issue 2782553004: Move TestingPrefService to use unique_ptr<Value> (Closed)
Patch Set: comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_sync/profile_sync_service_unittest.cc
diff --git a/components/browser_sync/profile_sync_service_unittest.cc b/components/browser_sync/profile_sync_service_unittest.cc
index 90a91cc2bb64072ddad92c6dee34f63be474e56c..aaa5d88da290e50a2990c5dd17eb40229d97422e 100644
--- a/components/browser_sync/profile_sync_service_unittest.cc
+++ b/components/browser_sync/profile_sync_service_unittest.cc
@@ -370,7 +370,8 @@ TEST_F(ProfileSyncServiceTest, InitialState) {
// Verify a successful initialization.
TEST_F(ProfileSyncServiceTest, SuccessfulInitialization) {
- prefs()->SetManagedPref(syncer::prefs::kSyncManaged, new base::Value(false));
+ prefs()->SetManagedPref(syncer::prefs::kSyncManaged,
+ base::MakeUnique<base::Value>(false));
IssueTestTokens();
CreateService(ProfileSyncService::AUTO_START);
ExpectDataTypeManagerCreation(1, GetDefaultConfigureCalledCallback());
@@ -382,7 +383,8 @@ TEST_F(ProfileSyncServiceTest, SuccessfulInitialization) {
// Verify a successful initialization.
TEST_F(ProfileSyncServiceTest, SuccessfulLocalBackendInitialization) {
- prefs()->SetManagedPref(syncer::prefs::kSyncManaged, new base::Value(false));
+ prefs()->SetManagedPref(syncer::prefs::kSyncManaged,
+ base::MakeUnique<base::Value>(false));
IssueTestTokens();
CreateServiceWithLocalSyncBackend();
ExpectDataTypeManagerCreation(1, GetDefaultConfigureCalledCallback());
@@ -395,7 +397,8 @@ TEST_F(ProfileSyncServiceTest, SuccessfulLocalBackendInitialization) {
// Verify that an initialization where first setup is not complete does not
// start up the backend.
TEST_F(ProfileSyncServiceTest, NeedsConfirmation) {
- prefs()->SetManagedPref(syncer::prefs::kSyncManaged, new base::Value(false));
+ prefs()->SetManagedPref(syncer::prefs::kSyncManaged,
+ base::MakeUnique<base::Value>(false));
IssueTestTokens();
CreateService(ProfileSyncService::MANUAL_START);
syncer::SyncPrefs sync_prefs(prefs());
@@ -430,7 +433,8 @@ TEST_F(ProfileSyncServiceTest, SetupInProgress) {
// Verify that disable by enterprise policy works.
TEST_F(ProfileSyncServiceTest, DisabledByPolicyBeforeInit) {
- prefs()->SetManagedPref(syncer::prefs::kSyncManaged, new base::Value(true));
+ prefs()->SetManagedPref(syncer::prefs::kSyncManaged,
+ base::MakeUnique<base::Value>(true));
IssueTestTokens();
CreateService(ProfileSyncService::AUTO_START);
InitializeForNthSync();
@@ -450,7 +454,8 @@ TEST_F(ProfileSyncServiceTest, DisabledByPolicyAfterInit) {
EXPECT_FALSE(service()->IsManaged());
EXPECT_TRUE(service()->IsSyncActive());
- prefs()->SetManagedPref(syncer::prefs::kSyncManaged, new base::Value(true));
+ prefs()->SetManagedPref(syncer::prefs::kSyncManaged,
+ base::MakeUnique<base::Value>(true));
EXPECT_TRUE(service()->IsManaged());
EXPECT_FALSE(service()->IsSyncActive());

Powered by Google App Engine
This is Rietveld 408576698