Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: chrome/browser/search_engines/template_url_service_unittest.cc

Issue 2782553004: Move TestingPrefService to use unique_ptr<Value> (Closed)
Patch Set: comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search_engines/template_url_service_unittest.cc
diff --git a/chrome/browser/search_engines/template_url_service_unittest.cc b/chrome/browser/search_engines/template_url_service_unittest.cc
index a255503755a61e2201c35905aa0ede7bdc35f74c..c3b8de661f0c6b8c009edbf0d440e4c34cd821b0 100644
--- a/chrome/browser/search_engines/template_url_service_unittest.cc
+++ b/chrome/browser/search_engines/template_url_service_unittest.cc
@@ -330,8 +330,9 @@ void TemplateURLServiceTest::SetOverriddenEngines() {
auto* prefs = test_util()->profile()->GetTestingPrefService();
prefs->SetUserPref(prefs::kSearchProviderOverridesVersion,
- new base::Value(1));
- prefs->SetUserPref(prefs::kSearchProviderOverrides, overrides_list.release());
+ base::MakeUnique<base::Value>(1));
+ prefs->SetUserPref(prefs::kSearchProviderOverrides,
+ std::move(overrides_list));
}
void TemplateURLServiceTest::VerifyObserverCount(int expected_changed_count) {

Powered by Google App Engine
This is Rietveld 408576698