chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc - Issue 2782553004: Move TestingPrefService to use unique_ptr<Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc

Issue 2782553004: Move TestingPrefService to use unique_ptr<Value> (Closed)

Patch Set: comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_target_determiner_unittest.cc ('k') | chrome/browser/extensions/extension_management_test_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc

diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc b/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc

index a2718f67e5ce40efcc9f35bd04faa219dbe37078..e4780b103be000f36337419d1b7b3afa97002442 100644

--- a/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc

+++ b/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc

@@ -857,7 +857,7 @@ TEST_F(DeveloperPrivateApiUnitTest, DeveloperPrivateDeleteExtensionErrors) {

// when DeveloperToolsDisabled policy is active.

TEST_F(DeveloperPrivateApiUnitTest, DeveloperPrivateDevModeDisabledPolicy) {

testing_pref_service()->SetManagedPref(prefs::kExtensionsUIDeveloperMode,

- new base::Value(false));

+ base::MakeUnique<base::Value>(false));

UpdateProfileConfigurationDevMode(true);