Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4258)

Unified Diff: chrome/browser/content_settings/content_settings_policy_provider_unittest.cc

Issue 2782553004: Move TestingPrefService to use unique_ptr<Value> (Closed)
Patch Set: comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/content_settings_policy_provider_unittest.cc
diff --git a/chrome/browser/content_settings/content_settings_policy_provider_unittest.cc b/chrome/browser/content_settings/content_settings_policy_provider_unittest.cc
index 23b0938d90f06a5174d4cd495efde8ca0e605854..433bbd7ab0bd9ecc74f8457d61add2ed48e3c2bc 100644
--- a/chrome/browser/content_settings/content_settings_policy_provider_unittest.cc
+++ b/chrome/browser/content_settings/content_settings_policy_provider_unittest.cc
@@ -9,6 +9,7 @@
#include "base/auto_reset.h"
#include "base/command_line.h"
+#include "base/memory/ptr_util.h"
#include "base/message_loop/message_loop.h"
#include "base/test/scoped_feature_list.h"
#include "chrome/browser/content_settings/content_settings_mock_observer.h"
@@ -48,7 +49,7 @@ TEST_F(PolicyProviderTest, DefaultGeolocationContentSetting) {
// Change the managed value of the default geolocation setting
prefs->SetManagedPref(prefs::kManagedDefaultGeolocationSetting,
- new base::Value(CONTENT_SETTING_BLOCK));
+ base::MakeUnique<base::Value>(CONTENT_SETTING_BLOCK));
rule_iterator = provider.GetRuleIterator(CONTENT_SETTINGS_TYPE_GEOLOCATION,
std::string(), false);
@@ -71,7 +72,7 @@ TEST_F(PolicyProviderTest, ManagedDefaultContentSettings) {
PolicyProvider provider(prefs);
prefs->SetManagedPref(prefs::kManagedDefaultPluginsSetting,
- new base::Value(CONTENT_SETTING_BLOCK));
+ base::MakeUnique<base::Value>(CONTENT_SETTING_BLOCK));
std::unique_ptr<RuleIterator> rule_iterator(provider.GetRuleIterator(
CONTENT_SETTINGS_TYPE_PLUGINS, std::string(), false));
@@ -98,9 +99,9 @@ TEST_F(PolicyProviderTest, ManagedDefaultPluginSettingsExperiment) {
// ForceDefaultPluginsSettingAsk overrides this to ASK.
prefs->SetManagedPref(prefs::kManagedDefaultPluginsSetting,
- new base::Value(CONTENT_SETTING_BLOCK));
+ base::MakeUnique<base::Value>(CONTENT_SETTING_BLOCK));
prefs->SetManagedPref(prefs::kManagedDefaultJavaScriptSetting,
- new base::Value(CONTENT_SETTING_BLOCK));
+ base::MakeUnique<base::Value>(CONTENT_SETTING_BLOCK));
std::unique_ptr<RuleIterator> plugin_rule_iterator(provider.GetRuleIterator(
CONTENT_SETTINGS_TYPE_PLUGINS, std::string(), false));
@@ -140,7 +141,7 @@ TEST_F(PolicyProviderTest, ObserveManagedSettingsChange) {
// Set the managed default-content-setting.
prefs->SetManagedPref(prefs::kManagedDefaultImagesSetting,
- new base::Value(CONTENT_SETTING_BLOCK));
+ base::MakeUnique<base::Value>(CONTENT_SETTING_BLOCK));
::testing::Mock::VerifyAndClearExpectations(&mock_observer);
EXPECT_CALL(mock_observer,
OnContentSettingChanged(_,
@@ -157,10 +158,9 @@ TEST_F(PolicyProviderTest, GettingManagedContentSettings) {
sync_preferences::TestingPrefServiceSyncable* prefs =
profile.GetTestingPrefService();
- base::ListValue* value = new base::ListValue();
+ auto value = base::MakeUnique<base::ListValue>();
value->AppendString("[*.]google.com");
- prefs->SetManagedPref(prefs::kManagedImagesBlockedForUrls,
- value);
+ prefs->SetManagedPref(prefs::kManagedImagesBlockedForUrls, std::move(value));
PolicyProvider provider(prefs);
@@ -213,10 +213,9 @@ TEST_F(PolicyProviderTest, ResourceIdentifier) {
sync_preferences::TestingPrefServiceSyncable* prefs =
profile.GetTestingPrefService();
- base::ListValue* value = new base::ListValue();
+ auto value = base::MakeUnique<base::ListValue>();
value->AppendString("[*.]google.com");
- prefs->SetManagedPref(prefs::kManagedPluginsAllowedForUrls,
- value);
+ prefs->SetManagedPref(prefs::kManagedPluginsAllowedForUrls, std::move(value));
PolicyProvider provider(prefs);
@@ -260,10 +259,10 @@ TEST_F(PolicyProviderTest, AutoSelectCertificateList) {
// certificates.
std::string pattern_str("\"pattern\":\"[*.]google.com\"");
std::string filter_str("\"filter\":{\"ISSUER\":{\"CN\":\"issuer name\"}}");
- base::ListValue* value = new base::ListValue();
+ auto value = base::MakeUnique<base::ListValue>();
value->AppendString("{" + pattern_str + "," + filter_str + "}");
prefs->SetManagedPref(prefs::kManagedAutoSelectCertificateForUrls,
- value);
+ std::move(value));
GURL youtube_url("https://www.youtube.com");
EXPECT_EQ(NULL, TestUtils::GetContentSettingValue(
&provider, youtube_url, youtube_url,

Powered by Google App Engine
This is Rietveld 408576698