chrome/browser/component_updater/chrome_component_updater_configurator_unittest.cc - Issue 2782553004: Move TestingPrefService to use unique_ptr<Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/chrome_component_updater_configurator_unittest.cc

Issue 2782553004: Move TestingPrefService to use unique_ptr<Value> (Closed)

Patch Set: comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/system/automatic_reboot_manager_unittest.cc ('k') | chrome/browser/content_settings/content_settings_policy_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/chrome_component_updater_configurator_unittest.cc

diff --git a/chrome/browser/component_updater/chrome_component_updater_configurator_unittest.cc b/chrome/browser/component_updater/chrome_component_updater_configurator_unittest.cc

index 8a81b285a3a04231397c50a61e4ba22e6a36ba29..c5e923c2c2e69064314b230d255c4f8c41c67db2 100644

--- a/chrome/browser/component_updater/chrome_component_updater_configurator_unittest.cc

+++ b/chrome/browser/component_updater/chrome_component_updater_configurator_unittest.cc

@@ -159,17 +159,17 @@ TEST_F(ChromeComponentUpdaterConfiguratorTest, TestEnabledComponentUpdates) {

// Tests the component updates are disabled.

pref_service()->SetManagedPref("component_updates.component_updates_enabled",

- new base::Value(false));

+ base::MakeUnique<base::Value>(false));

EXPECT_FALSE(config->EnabledComponentUpdates());

// Tests the component updates are enabled.

pref_service()->SetManagedPref("component_updates.component_updates_enabled",

- new base::Value(true));

+ base::MakeUnique<base::Value>(true));

EXPECT_TRUE(config->EnabledComponentUpdates());

// Sanity check setting the preference back to |false| and then removing it.

pref_service()->SetManagedPref("component_updates.component_updates_enabled",

- new base::Value(false));

+ base::MakeUnique<base::Value>(false));

EXPECT_FALSE(config->EnabledComponentUpdates());

pref_service()->RemoveManagedPref(

"component_updates.component_updates_enabled");