Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5523)

Unified Diff: chrome/browser/android/search_geolocation/search_geolocation_service_unittest.cc

Issue 2782553004: Move TestingPrefService to use unique_ptr<Value> (Closed)
Patch Set: comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/bookmarks/managed_bookmark_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/search_geolocation/search_geolocation_service_unittest.cc
diff --git a/chrome/browser/android/search_geolocation/search_geolocation_service_unittest.cc b/chrome/browser/android/search_geolocation/search_geolocation_service_unittest.cc
index 260a98eaa954358a640a43f584fece04c5db30cf..a74026eba5ce0d6d8f16bbc0c53479b6cbf791e2 100644
--- a/chrome/browser/android/search_geolocation/search_geolocation_service_unittest.cc
+++ b/chrome/browser/android/search_geolocation/search_geolocation_service_unittest.cc
@@ -195,7 +195,7 @@ TEST_F(SearchGeolocationServiceTest, UseDSEGeolocationSetting) {
// False if the content setting is enterprise ask.
profile()->GetTestingPrefService()->SetManagedPref(
prefs::kManagedDefaultGeolocationSetting,
- new base::Value(CONTENT_SETTING_ASK));
+ base::MakeUnique<base::Value>(CONTENT_SETTING_ASK));
EXPECT_FALSE(GetService()->UseDSEGeolocationSetting(ToOrigin(kGoogleURL)));
}
@@ -245,7 +245,7 @@ TEST_F(SearchGeolocationServiceTest, SetDSEGeolocationSetting) {
GetService()->SetDSEGeolocationSetting(true);
profile()->GetTestingPrefService()->SetManagedPref(
prefs::kManagedDefaultGeolocationSetting,
- new base::Value(CONTENT_SETTING_ASK));
+ base::MakeUnique<base::Value>(CONTENT_SETTING_ASK));
EXPECT_TRUE(GetService()->GetDSEGeolocationSetting());
GetService()->SetDSEGeolocationSetting(false);
EXPECT_TRUE(GetService()->GetDSEGeolocationSetting());
« no previous file with comments | « no previous file | chrome/browser/bookmarks/managed_bookmark_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698