Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2782533002: Report errors for the new top-level inference rules. (Closed)

Created:
3 years, 9 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Report errors for the new top-level inference rules. We also stop type inference most of these cases with task based analysis. Summary based analysis is not changed yet. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/27ab6478b9072dfc7cabbc63a36dc3adef463998

Patch Set 1 #

Patch Set 2 : Convert generic method inference from top-level to in-body. #

Total comments: 2

Patch Set 3 : Update DDC expectations. #

Patch Set 4 : Update error messages for the review comments. #

Patch Set 5 : Update language_strong status for analyzer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1213 lines, -1364 lines) Patch
M pkg/analyzer/lib/error/error.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/error/codes.dart View 1 2 3 1 chunk +44 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 6 chunks +21 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 6 chunks +133 lines, -129 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +11 lines, -11 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong/checker.dart View 7 chunks +169 lines, -113 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong_mode.dart View 1 chunk +59 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_ast_test.dart View 6 chunks +7 lines, -640 lines 0 comments Download
M pkg/analyzer/test/src/summary/top_level_inference_test.dart View 4 chunks +351 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 2 chunks +3 lines, -7 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 3 chunks +7 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 1 92 chunks +335 lines, -449 lines 0 comments Download
M pkg/dev_compiler/test/not_yet_strong_tests.dart View 1 2 15 chunks +37 lines, -0 lines 0 comments Download
M pkg/dev_compiler/tool/sdk_expected_errors.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/language_strong/language_strong.status View 1 2 3 4 1 chunk +27 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 9 months ago (2017-03-28 03:29:26 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2782533002/diff/20001/pkg/analyzer/lib/src/error/codes.dart File pkg/analyzer/lib/src/error/codes.dart (right): https://codereview.chromium.org/2782533002/diff/20001/pkg/analyzer/lib/src/error/codes.dart#newcode4978 pkg/analyzer/lib/src/error/codes.dart:4978: "Try adding an explicit type to the variable ...
3 years, 8 months ago (2017-03-28 13:41:23 UTC) #2
scheglov
3 years, 8 months ago (2017-03-28 16:41:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
27ab6478b9072dfc7cabbc63a36dc3adef463998 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698