Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 278253002: Port gfx_jni_headers target to GN build. (Closed)

Created:
6 years, 7 months ago by tfarina
Modified:
6 years, 7 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, Ben Goodger (Google), cjhopman, danakj, brettw, scottmg
Visibility:
Public.

Description

Port gfx_jni_headers target to GN build. In Debug build: $ gn gen out/Debug --args='os="android" cpu_arch="x86"' $ ninja -C out/Debug gfx_jni_headers In Release build: $ gn gen out/Debug --args='is_debug=false os="android" cpu_arch="x86"' $ ninja -C out/Release gfx_jni_headers BUG=None TEST=see above R=cjhopman@chromium.org TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270319

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M ui/gfx/BUILD.gn View 3 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
6 years, 7 months ago (2014-05-11 23:59:19 UTC) #1
tfarina
Trying with Scott. Moving Brett to CC list. Scott, do you mind reviewing this to ...
6 years, 7 months ago (2014-05-13 19:26:20 UTC) #2
scottmg
->Chris
6 years, 7 months ago (2014-05-13 19:29:54 UTC) #3
cjhopman
lgtm
6 years, 7 months ago (2014-05-13 19:50:30 UTC) #4
tfarina
6 years, 7 months ago (2014-05-14 03:18:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r270319 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698