chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.h - Issue 2782503004: Prerender: clarify how FCP works in non-prerendered cases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.h

Issue 2782503004: Prerender: clarify how FCP works in non-prerendered cases (Closed)

Patch Set: clarified the comment a little Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.h ('k') | chrome/browser/prerender/prerender_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.h

diff --git a/chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.h

index 1aac140e78e094a445d955998078fc6f6d85f9cb..1db726166c7dccda38fc0a7d677acf6b0fa4d180 100644

--- a/chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.h

+++ b/chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.h

@@ -17,7 +17,11 @@ namespace prerender {

class PrerenderManager;

}

-// Observer recording metrics related to prerender.

+// Observer responsible for recording First Contentful Paing metrics related to

+// Prerender.

+//

+// To record FCP metrics for non-Prerender loads, the

+// |NoStatePrefetchPageLoadMetricsObserver| is used.

class PrerenderPageLoadMetricsObserver

: public page_load_metrics::PageLoadMetricsObserver {

public: