Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2782503003: Extract NativeClassResolver from NativeResolutionEnqueuer (Closed)

Created:
3 years, 8 months ago by Johnni Winther
Modified:
3 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extract NativeClassResolver from NativeResolutionEnqueuer This is a step towards making NativeResolutionEnqueuer and NativeCodegenEnqueuer element model agnostic. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/bd40a53baa245f9f8329e78106099f47968260b8

Patch Set 1 #

Patch Set 2 : Remove imports #

Patch Set 3 : Remove unused getter. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -189 lines) Patch
M pkg/compiler/lib/src/js_backend/backend.dart View 7 chunks +13 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 1 2 8 chunks +12 lines, -177 lines 0 comments Download
M pkg/compiler/lib/src/native/resolver.dart View 3 chunks +191 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 8 months ago (2017-03-28 13:25:01 UTC) #2
Emily Fortuna
lgtm
3 years, 8 months ago (2017-03-28 18:22:56 UTC) #3
Johnni Winther
3 years, 8 months ago (2017-03-29 09:05:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
bd40a53baa245f9f8329e78106099f47968260b8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698