Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2164)

Unified Diff: chrome/browser/resources/settings/languages_page/add_languages_dialog.js

Issue 2782493003: MD Settings: Display languages native display name. (Closed)
Patch Set: More Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/languages_page/add_languages_dialog.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/languages_page/add_languages_dialog.js
diff --git a/chrome/browser/resources/settings/languages_page/add_languages_dialog.js b/chrome/browser/resources/settings/languages_page/add_languages_dialog.js
index 70cd755e04b191b73c2d49227eac03620bcbfb6b..e8d2d277ccedcdc6f8108d471098c07871ab73ec 100644
--- a/chrome/browser/resources/settings/languages_page/add_languages_dialog.js
+++ b/chrome/browser/resources/settings/languages_page/add_languages_dialog.js
@@ -73,6 +73,19 @@ Polymer({
},
/**
+ * @param {!chrome.languageSettingsPrivate.Language} language
+ * @return {string} The text to be displayed.
+ * @private
+ */
+ getDisplayText_: function(language) {
+ var displayText = language.displayName;
+ // If the native name is different, add it.
+ if (language.displayName != language.nativeDisplayName)
+ displayText += ' - ' + language.nativeDisplayName;
dpapad 2017/03/27 22:46:29 This is on par with the old Options, see https://c
+ return displayText;
+ },
+
+ /**
* True if the user has chosen to add this language (checked its checkbox).
* @param {string} languageCode
* @return {boolean}
« no previous file with comments | « chrome/browser/resources/settings/languages_page/add_languages_dialog.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698