third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp - Issue 2782373002: Remove MediaControls methods needed for the Cast button

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp

Issue 2782373002: Remove MediaControls methods needed for the Cast button (Closed)

Patch Set: Fixed MediaControlsImplTest Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ('k') | third_party/WebKit/Source/core/html/media/MediaControls.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp

index f5317b77cd8b25a930436c6bb519404131fcfbd5..fe4d41e0a8021b1804a1152b3ba4e3dc94d0dac0 100644

--- a/third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp

@@ -96,6 +96,8 @@ TEST_F(HTMLMediaElementEventListenersTest, RemovingFromDocumentCollectsAll) {

EXPECT_TRUE(persistent_video->HasEventListeners());

}

+ testing::RunPendingTasks();

ThreadState::Current()->CollectAllGarbage();

// They have been GC'd.

@@ -123,6 +125,8 @@ TEST_F(HTMLMediaElementEventListenersTest,

EXPECT_TRUE(GetDocument().HasEventListeners());

EXPECT_TRUE(Video()->HasEventListeners());

+ testing::RunPendingTasks();

ThreadState::Current()->CollectAllGarbage();

EXPECT_NE(Video(), nullptr);