Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h

Issue 2782373002: Remove MediaControls methods needed for the Cast button (Closed)
Patch Set: Fixed more tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
diff --git a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
index 562f668dfcf95f355e9054c8fd22fd4631a63c8c..8f3955d54560ca6241f594af75f6ff73d056dd0d 100644
--- a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
+++ b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
@@ -84,13 +84,6 @@ class MODULES_EXPORT MediaControlsImpl final : public HTMLDivElement,
// HTMLTrackElement failed to load because there is no web exposed way to
// be notified on the TextTrack object. See https://crbug.com/669977
void OnTrackElementFailedToLoad() override { OnTextTracksAddedOrRemoved(); }
- // TODO(mlamouri): the following methods will be able to become private when
- // the controls have to modules/ and have access to RemotePlayback.
- void OnRemotePlaybackAvailabilityChanged() override {
- RefreshCastButtonVisibility();
- }
- void OnRemotePlaybackConnecting() override { StartedCasting(); }
- void OnRemotePlaybackDisconnected() override { StoppedCasting(); }
// TODO(mlamouri): this method is needed in order to notify the controls that
// the attribute have changed.
void OnDisableRemotePlaybackAttributeChanged() override {
@@ -199,8 +192,6 @@ class MODULES_EXPORT MediaControlsImpl final : public HTMLDivElement,
bool ContainsRelatedTarget(Event*);
// Internal cast related methods.
- void StartedCasting();
- void StoppedCasting();
void RefreshCastButtonVisibility();
void RefreshCastButtonVisibilityWithoutUpdate();

Powered by Google App Engine
This is Rietveld 408576698