Remove MediaControls methods needed for the Cast button

third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef RemotePlayback_h
 #define RemotePlayback_h
 
 #include "bindings/core/v8/ActiveScriptWrappable.h"
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/TraceWrapperMember.h"
 #include "core/dom/ExecutionContext.h"
 #include "core/events/EventTarget.h"
 #include "modules/ModulesExport.h"
 #include "platform/heap/Handle.h"
 #include "platform/wtf/Compiler.h"
+#include "platform/wtf/Functional.h"
 #include "platform/wtf/text/AtomicString.h"
 #include "platform/wtf/text/WTFString.h"
 #include "public/platform/modules/remoteplayback/WebRemotePlaybackAvailability.h"
 #include "public/platform/modules/remoteplayback/WebRemotePlaybackClient.h"
 #include "public/platform/modules/remoteplayback/WebRemotePlaybackState.h"
 
 namespace blink {
 
 class HTMLMediaElement;
 class RemotePlaybackAvailabilityCallback;
@@ skipping 38 matching lines @@
   String state() const;
 
   // ScriptWrappable implementation.
   bool HasPendingActivity() const final;
 
   DEFINE_ATTRIBUTE_EVENT_LISTENER(connecting);
   DEFINE_ATTRIBUTE_EVENT_LISTENER(connect);
   DEFINE_ATTRIBUTE_EVENT_LISTENER(disconnect);
 
   DECLARE_VIRTUAL_TRACE();
-  DECLARE_VIRTUAL_TRACE_WRAPPERS();
 
  private:
+  friend class MediaControlCastButtonElement;
+  friend class MediaControlsMediaEventListener;

[mlamouri (slow - plz ping), 2017/04/25 12:19:21]

Do you need these for PromptInternal() and GetState()? If yes, maybe make the
methods public? I would prefer to avoid such dependencies.

[whywhat, 2017/04/25 15:45:37]

Prompt and State are used by the button.
Watch/CancelAvailabilityInternal are used by the MediaEventListeners.
Making them public sgtm.

   friend class V8RemotePlayback;
   friend class RemotePlaybackTest;
 
+  // Wraps either a WTF::Closure or RemotePlaybackAvailabilityCallback object
+  // to be kept in the |availability_callbacks_| map.
+  class AvailabilityCallback final
+      : public GarbageCollectedFinalized<AvailabilityCallback> {

[mlamouri (slow - plz ping), 2017/04/25 12:19:21]

Do you need to declare the class here? I mean, apart from the name.

[whywhat, 2017/04/25 15:45:37]

Would you prefer it to be in a separate header/cpp file?

[whywhat, 2017/04/25 22:31:23]

It's needed to be in the header since it's used by C++ clients of
RemotePlayback.

+    WTF_MAKE_NONCOPYABLE(AvailabilityCallback);
+
+   public:
+    explicit AvailabilityCallback(RemotePlaybackAvailabilityCallback*);
+    explicit AvailabilityCallback(std::unique_ptr<WTF::Closure>);
+    ~AvailabilityCallback() = default;
+
+    void Run(RemotePlayback*, bool new_availability);
+
+    DECLARE_VIRTUAL_TRACE_WRAPPERS();
+    DEFINE_INLINE_VIRTUAL_TRACE() {}
+
+   private:
+    // Only one of these members must be set.
+    TraceWrapperMember<RemotePlaybackAvailabilityCallback> bindings_cb_;
+    std::unique_ptr<WTF::Closure> internal_cb_;
+  };
+
   explicit RemotePlayback(HTMLMediaElement&);
 
+  // The implementation of prompt(). Used by the native remote playback button.
+  void PromptInternal();
+
+  // The implementation of watchAvailability() and cancelWatchAvailability().
+  int WatchAvailabilityInternal(AvailabilityCallback*);
+  bool CancelWatchAvailabilityInternal(int id);
+
+  WebRemotePlaybackState GetState() const { return state_; }
+
   // Calls the specified availability callback with the current availability.
   // Need a void() method to post it as a task.
   void NotifyInitialAvailability(int callback_id);
 
   // WebRemotePlaybackClient implementation.
   void StateChanged(WebRemotePlaybackState) override;
   void AvailabilityChanged(WebRemotePlaybackAvailability) override;
   void PromptCancelled() override;
   bool RemotePlaybackAvailable() const override;
 
   WebRemotePlaybackState state_;
   WebRemotePlaybackAvailability availability_;
-  HeapHashMap<int, TraceWrapperMember<RemotePlaybackAvailabilityCallback>>
-      availability_callbacks_;
+  HeapHashMap<int, Member<AvailabilityCallback>> availability_callbacks_;
   Member<HTMLMediaElement> media_element_;
   Member<ScriptPromiseResolver> prompt_promise_resolver_;
 };
 
 }  // namespace blink
 
 #endif  // RemotePlayback_h