Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: chrome/browser/android/webapk/webapk_update_data_fetcher.cc

Issue 2782313002: Add static method WebApkIconHasher::DownloadAndComputeMurmur2Hash (Closed)
Patch Set: Delete non-static download method` Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/webapk/webapk_update_data_fetcher.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/webapk/webapk_update_data_fetcher.cc
diff --git a/chrome/browser/android/webapk/webapk_update_data_fetcher.cc b/chrome/browser/android/webapk/webapk_update_data_fetcher.cc
index 2443cd0722bd8ef894a0ef5591ad6448bde8ae89..69f626329dbb8f4210c7c302615a1a4b29af0491 100644
--- a/chrome/browser/android/webapk/webapk_update_data_fetcher.cc
+++ b/chrome/browser/android/webapk/webapk_update_data_fetcher.cc
@@ -155,17 +155,14 @@ void WebApkUpdateDataFetcher::OnDidGetInstallableData(
Profile* profile =
Profile::FromBrowserContext(web_contents()->GetBrowserContext());
- icon_hasher_.reset(new WebApkIconHasher(
+ WebApkIconHasher::DownloadAndComputeMurmur2Hash(
profile->GetRequestContext(), data.primary_icon_url,
base::Bind(&WebApkUpdateDataFetcher::OnGotIconMurmur2Hash,
- weak_ptr_factory_.GetWeakPtr())));
- icon_hasher_->DownloadAndComputeMurmur2Hash();
+ weak_ptr_factory_.GetWeakPtr()));
}
void WebApkUpdateDataFetcher::OnGotIconMurmur2Hash(
const std::string& best_primary_icon_murmur2_hash) {
- icon_hasher_.reset();
-
if (best_primary_icon_murmur2_hash.empty()) {
OnWebManifestNotWebApkCompatible();
return;
« no previous file with comments | « chrome/browser/android/webapk/webapk_update_data_fetcher.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698