Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2782263002: Add GetWebContents to ShellDelegate. (Closed)

Created:
3 years, 8 months ago by wutao
Modified:
3 years, 8 months ago
Reviewers:
danakj, oshima, bruthig
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not need this function. Close this cl. Add GetWebContents to ShellDelegate. To get webcontents in ash. When screen rotates, we can observe the compositor frame swap on the webcontents so that to send the second copy output request after screen rotation. BUG=678763

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -2 lines) Patch
M ash/common/shell_delegate.h View 4 chunks +9 lines, -2 lines 0 comments Download
M ash/mus/shell_delegate_mus.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/mus/shell_delegate_mus.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ash/shell/shell_delegate_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 4 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
wutao
Hi Oshima, Could you please look this cl. Thanks, Tao
3 years, 8 months ago (2017-03-29 18:31:37 UTC) #2
danakj
I don't think it's okay to have ash use content. Also we should consider that ...
3 years, 8 months ago (2017-03-29 18:38:14 UTC) #4
wutao
On 2017/03/29 18:38:14, danakj wrote: > I don't think it's okay to have ash use ...
3 years, 8 months ago (2017-03-29 19:01:58 UTC) #5
danakj
On Wed, Mar 29, 2017 at 3:01 PM, <wutao@chromium.org> wrote: > On 2017/03/29 18:38:14, danakj ...
3 years, 8 months ago (2017-03-29 19:15:34 UTC) #6
wutao
3 years, 8 months ago (2017-03-29 19:19:30 UTC) #7
> https://codereview.chromium.org/2773433003/ should fix it.

Great! I will merge and try.

Powered by Google App Engine
This is Rietveld 408576698