Add GetWebContents to ShellDelegate.

Do not need this function. Close this cl.

Add GetWebContents to ShellDelegate.

To get webcontents in ash. When screen rotates, we can observe the
compositor frame swap on the webcontents so that to send the second copy
output request after screen rotation.

BUG=678763

[wutao, 2017-03-29 18:31:36]

wutao@chromium.org changed reviewers:
+ bruthig@chromium.org, oshima@chromium.org

[wutao, 2017-03-29 18:31:37]

Hi Oshima,

Could you please look this cl.

Thanks,
Tao

[danakj, 2017-03-29 18:38:14]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2017-03-29 18:38:14]

I don't think it's okay to have ash use content.

Also we should consider that the UI scene is an atomic thing. When you call
resize and insert a copy request, they happen at the same time. With the resize
lock working, we should also see them happen together with the renderer resize
since it waits for them.

[wutao, 2017-03-29 19:01:58]

On 2017/03/29 18:38:14, danakj wrote:
> I don't think it's okay to have ash use content.
> 
> Also we should consider that the UI scene is an atomic thing. When you call
> resize and insert a copy request, they happen at the same time. With the
resize
> lock working, we should also see them happen together with the renderer resize
> since it waits for them.

Hi Dana,

Do you suggest fixing the resize_lock_ instead? If we can fix it, then my code
will be much cleaner.
Otherwise observing the webcontents seems the only way now?

Tao

[danakj, 2017-03-29 19:15:34]

On Wed, Mar 29, 2017 at 3:01 PM, <wutao@chromium.org> wrote:

> On 2017/03/29 18:38:14, danakj wrote:
> > I don't think it's okay to have ash use content.
> >
> > Also we should consider that the UI scene is an atomic thing. When you
> call
> > resize and insert a copy request, they happen at the same time. With the
> resize
> > lock working, we should also see them happen together with the renderer
> resize
> > since it waits for them.
>
> Hi Dana,
>
> Do you suggest fixing the resize_lock_ instead? If we can fix it, then my
> code
> will be much cleaner.
>

https://codereview.chromium.org/2773433003/ should fix it.


> Otherwise observing the webcontents seems the only way now?
>
> Tao
>
> https://codereview.chromium.org/2782263002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[wutao, 2017-03-29 19:19:30]

> https://codereview.chromium.org/2773433003/ should fix it.

Great! I will merge and try.

[wutao, 2017-04-10 19:57:19]

Description was changed from

==========
Add GetWebContents to ShellDelegate.

To get webcontents in ash. When screen rotates, we can observe the
compositor frame swap on the webcontents so that to send the second copy
output request after screen rotation.

BUG=678763
==========

to

==========
Do not need this function. Close this cl.

Add GetWebContents to ShellDelegate.

To get webcontents in ash. When screen rotates, we can observe the
compositor frame swap on the webcontents so that to send the second copy
output request after screen rotation.

BUG=678763
==========