Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2782213002: Add requirejs to repo for DDC (Closed)

Created:
3 years, 8 months ago by vsm
Modified:
3 years, 8 months ago
Reviewers:
Bill Hesse, jakemac
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2285 lines, -1 line) Patch
M pkg/dev_compiler/package.json View 1 chunk +1 line, -1 line 0 comments Download
A third_party/requirejs/LICENSE View 1 chunk +45 lines, -0 lines 0 comments Download
A third_party/requirejs/README.google View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/requirejs/README.md View 1 chunk +79 lines, -0 lines 0 comments Download
A third_party/requirejs/require.js View 1 chunk +2145 lines, -0 lines 0 comments Download
M tools/create_sdk.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
vsm
3 years, 8 months ago (2017-03-29 14:35:02 UTC) #3
Bill Hesse
lgtm This looks OK. The license seems to fall under the "attribution" category in the ...
3 years, 8 months ago (2017-03-29 14:47:30 UTC) #4
vsm
On 2017/03/29 14:47:30, Bill Hesse wrote: > lgtm > > This looks OK. The license ...
3 years, 8 months ago (2017-03-29 14:59:59 UTC) #5
jakemac
lgtm
3 years, 8 months ago (2017-03-29 15:04:35 UTC) #6
vsm
3 years, 8 months ago (2017-03-29 15:05:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7a809bcc02986a426451a92886e9aa469508b098 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698