chrome/browser/BUILD.gn - Issue 2782113002: Add component for feature engagement tracking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/BUILD.gn

Issue 2782113002: Add component for feature engagement tracking. (Closed)

Patch Set: Remove multi-line comment and change public component target to source_set Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java_sources.gni ('k') | chrome/browser/android/chrome_jni_registrar.cc » ('j') | chrome/browser/feature_engagement_tracker/feature_engagement_tracker_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/BUILD.gn

diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn

index 6bee5f7a102721e4ffa47a153183591ee740b56c..c42c1d1a6603d5376cecd9729b97a80d5c83c19c 100644

--- a/chrome/browser/BUILD.gn

+++ b/chrome/browser/BUILD.gn

@@ -403,6 +403,8 @@ split_static_library("browser") {

"favicon/favicon_utils.h",

"favicon/large_icon_service_factory.cc",

"favicon/large_icon_service_factory.h",

+ "feature_engagement_tracker/feature_engagement_tracker_factory.cc",

+ "feature_engagement_tracker/feature_engagement_tracker_factory.h",

"file_select_helper.cc",

"file_select_helper.h",

"file_select_helper_mac.mm",

@@ -1455,6 +1457,7 @@ split_static_library("browser") {

"//components/favicon/content",

"//components/favicon/core",

"//components/favicon_base",

+ "//components/feature_engagement_tracker",

"//components/flags_ui",

"//components/gcm_driver",

"//components/google/core/browser",

@@ -2742,6 +2745,8 @@ split_static_library("browser") {

"android/download/ui/thumbnail_provider.h",

"android/favicon_helper.cc",

"android/favicon_helper.h",

+ "android/feature_engagement_tracker/feature_engagement_tracker_factory_android.cc",

+ "android/feature_engagement_tracker/feature_engagement_tracker_factory_android.h",

"android/feature_utilities.cc",

"android/feature_utilities.h",

"android/feedback/connectivity_checker.cc",

@@ -4058,6 +4063,7 @@ if (is_android) {

"../android/java/src/org/chromium/chrome/browser/engagement/SiteEngagementService.java",

"../android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java",

"../android/java/src/org/chromium/chrome/browser/favicon/LargeIconBridge.java",

+ "../android/java/src/org/chromium/chrome/browser/feature_engagement_tracker/FeatureEngagementTrackerFactory.java",

"../android/java/src/org/chromium/chrome/browser/feedback/ConnectivityChecker.java",

"../android/java/src/org/chromium/chrome/browser/feedback/ScreenshotTask.java",

"../android/java/src/org/chromium/chrome/browser/findinpage/FindInPageBridge.java",