Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Side by Side Diff: base/android/jni_android.cc

Issue 2782063005: Explicitly specify whether to emit frame pointers by default. (Closed)
Patch Set: arm64 -> arm Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/android/jni_android.h ('k') | base/debug/stack_trace.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/android/jni_android.h" 5 #include "base/android/jni_android.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <map> 9 #include <map>
10 10
(...skipping 11 matching lines...) Expand all
22 using base::android::ScopedJavaLocalRef; 22 using base::android::ScopedJavaLocalRef;
23 23
24 base::android::JniRegistrationType g_jni_registration_type = 24 base::android::JniRegistrationType g_jni_registration_type =
25 base::android::ALL_JNI_REGISTRATION; 25 base::android::ALL_JNI_REGISTRATION;
26 26
27 JavaVM* g_jvm = NULL; 27 JavaVM* g_jvm = NULL;
28 base::LazyInstance<base::android::ScopedJavaGlobalRef<jobject>>::Leaky 28 base::LazyInstance<base::android::ScopedJavaGlobalRef<jobject>>::Leaky
29 g_class_loader = LAZY_INSTANCE_INITIALIZER; 29 g_class_loader = LAZY_INSTANCE_INITIALIZER;
30 jmethodID g_class_loader_load_class_method_id = 0; 30 jmethodID g_class_loader_load_class_method_id = 0;
31 31
32 #if BUILDFLAG(ENABLE_PROFILING) && HAVE_TRACE_STACK_FRAME_POINTERS 32 #if BUILDFLAG(CAN_UNWIND_WITH_FRAME_POINTERS)
33 base::LazyInstance<base::ThreadLocalPointer<void>>::Leaky 33 base::LazyInstance<base::ThreadLocalPointer<void>>::Leaky
34 g_stack_frame_pointer = LAZY_INSTANCE_INITIALIZER; 34 g_stack_frame_pointer = LAZY_INSTANCE_INITIALIZER;
35 #endif 35 #endif
36 36
37 } // namespace 37 } // namespace
38 38
39 namespace base { 39 namespace base {
40 namespace android { 40 namespace android {
41 41
42 JniRegistrationType GetJniRegistrationType() { 42 JniRegistrationType GetJniRegistrationType() {
(...skipping 239 matching lines...) Expand 10 before | Expand all | Expand 10 after
282 282
283 // Call ByteArrayOutputStream.toString() 283 // Call ByteArrayOutputStream.toString()
284 ScopedJavaLocalRef<jstring> exception_string( 284 ScopedJavaLocalRef<jstring> exception_string(
285 env, static_cast<jstring>( 285 env, static_cast<jstring>(
286 env->CallObjectMethod(bytearray_output_stream.obj(), 286 env->CallObjectMethod(bytearray_output_stream.obj(),
287 bytearray_output_stream_tostring))); 287 bytearray_output_stream_tostring)));
288 288
289 return ConvertJavaStringToUTF8(exception_string); 289 return ConvertJavaStringToUTF8(exception_string);
290 } 290 }
291 291
292 #if BUILDFLAG(ENABLE_PROFILING) && HAVE_TRACE_STACK_FRAME_POINTERS 292 #if BUILDFLAG(CAN_UNWIND_WITH_FRAME_POINTERS)
293 293
294 JNIStackFrameSaver::JNIStackFrameSaver(void* current_fp) { 294 JNIStackFrameSaver::JNIStackFrameSaver(void* current_fp) {
295 previous_fp_ = g_stack_frame_pointer.Pointer()->Get(); 295 previous_fp_ = g_stack_frame_pointer.Pointer()->Get();
296 g_stack_frame_pointer.Pointer()->Set(current_fp); 296 g_stack_frame_pointer.Pointer()->Set(current_fp);
297 } 297 }
298 298
299 JNIStackFrameSaver::~JNIStackFrameSaver() { 299 JNIStackFrameSaver::~JNIStackFrameSaver() {
300 g_stack_frame_pointer.Pointer()->Set(previous_fp_); 300 g_stack_frame_pointer.Pointer()->Set(previous_fp_);
301 } 301 }
302 302
303 void* JNIStackFrameSaver::SavedFrame() { 303 void* JNIStackFrameSaver::SavedFrame() {
304 return g_stack_frame_pointer.Pointer()->Get(); 304 return g_stack_frame_pointer.Pointer()->Get();
305 } 305 }
306 306
307 #endif // ENABLE_PROFILING && HAVE_TRACE_STACK_FRAME_POINTERS 307 #endif // BUILDFLAG(CAN_UNWIND_WITH_FRAME_POINTERS)
308 308
309 } // namespace android 309 } // namespace android
310 } // namespace base 310 } // namespace base
OLDNEW
« no previous file with comments | « base/android/jni_android.h ('k') | base/debug/stack_trace.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698