Explicitly specify whether to emit frame pointers by default.

build/config/compiler/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/chrome_build.gni")
 import("//build/config/chromecast_build.gni")
 import("//build/config/compiler/compiler.gni")
 import("//build/config/nacl/config.gni")
 import("//build/toolchain/cc_wrapper.gni")
@@ skipping 1276 matching lines @@
 # default config and then adding the named one you want:
 #
 #   configs -= [ "//build/config/compiler:default_optimization" ]
 #   configs += [ "//build/config/compiler:optimize_max" ]
 
 # Shared settings for both "optimize" and "optimize_max" configs.
 # IMPORTANT: On Windows "/O1" and "/O2" must go before the common flags.
 if (is_win) {
   common_optimize_on_cflags = [
     "/Ob2",  # Both explicit and auto inlining.
-    "/Oy-",  # Disable omitting frame pointers, must be after /O2.
     "/d2Zi+",  # Improve debugging of optimized code.
     "/Zc:inline",  # Remove unreferenced COMDAT (faster links).
   ]
   if (!is_asan) {
     common_optimize_on_cflags += [
       # Put data in separate COMDATs. This allows the linker
       # to put bit-identical constants at the same address even if
       # they're unrelated constants, which saves binary size.
       # This optimization can't be used when ASan is enabled because
       # it is not compatible with the ASan ODR checker.
@@ skipping 69 matching lines @@
     common_optimize_on_ldflags += [
       # Specifically tell the linker to perform optimizations.
       # See http://lwn.net/Articles/192624/ .
       "-Wl,-O1",
       "-Wl,--gc-sections",
     ]
   }
 }
 
 config("default_stack_frames") {
-  if (is_posix && !(is_mac || is_ios)) {
-    if (using_sanitizer || enable_profiling || is_debug ||
-        current_cpu == "arm64") {
-      # Explicitly ask for frame pointers, otherwise:
-      # * Stacks may be missing for sanitizer and profiling builds.
-      # * Debug tcmalloc can crash (crbug.com/636489).
-      # * Stacks may be missing for arm64 crash dumps (crbug.com/391706).
+  if (is_posix) {
+    if (enabled_frame_pointers) {
       cflags = [ "-fno-omit-frame-pointer" ]
-    } else if (is_android) {
+    } else {
       cflags = [ "-fomit-frame-pointer" ]

[Mark Mentovai, 2017/03/30 23:43:29]

I think we’d never want this in a debug-ish configuration, which sounds like
it’s what common_optimize_on_cflags gives you for Windows. Why should
non-Windows behave differently?

[erikchen, 2017/04/03 06:33:39]

I'm just maintaining the previous behavior. 

     }
   }
+
+  if (is_win) {
+    if (enabled_frame_pointers) {
+      common_optimize_on_cflags += [ "/Oy-" ]  # Disable omitting frame pointers, must be after /O2.
+    } else {
+      common_optimize_on_cflags += [ "/Oy" ]
+    }
+  }
 }
 
 # Default "optimization on" config.
 config("optimize") {
   if (is_win) {
     # TODO(thakis): Remove is_clang here, https://crbug.com/598772
     if (is_official_build && full_wpo_on_official && !is_clang) {
       common_optimize_on_cflags += [
         "/GL",  # Whole program optimization.
 
@@ skipping 306 matching lines @@
 
 if (is_ios || is_mac) {
   # On Mac and iOS, this enables support for ARC (automatic ref-counting).
   # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
   config("enable_arc") {
     common_flags = [ "-fobjc-arc" ]
     cflags_objc = common_flags
     cflags_objcc = common_flags
   }
 }