Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 2782053003: Await cancellation in the Kernel await transformer (Closed)

Created:
3 years, 8 months ago by Kevin Millikin (Google)
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Await cancellation in the Kernel await transformer When an an async for loop's StreamIterator is canceled the returned Future should be awaited. Closes issue 29192. BUG=https://github.com/dart-lang/sdk/issues/29192 R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/4de94b2d7b09f7207b2de58c610d102d691d2e4b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M pkg/kernel/lib/transformations/continuation.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M tests/language/language_kernel.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Kevin Millikin (Google)
3 years, 8 months ago (2017-03-29 13:16:08 UTC) #3
ahe
lgtm
3 years, 8 months ago (2017-03-29 13:19:57 UTC) #4
Kevin Millikin (Google)
3 years, 8 months ago (2017-03-29 13:20:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4de94b2d7b09f7207b2de58c610d102d691d2e4b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698