content/browser/media/session/media_session_impl.cc - Issue 2782053002: MediaSession: Stop observers on MediaSession destruction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/session/media_session_impl.cc

Issue 2782053002: MediaSession: Stop observers on MediaSession destruction (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/media/session/media_session_impl.cc

diff --git a/content/browser/media/session/media_session_impl.cc b/content/browser/media/session/media_session_impl.cc

index e2e554653b7c795504b18975930c0d1d8b468722..c9a513b50b453629502e9a7492fd9569d41d93e2 100644

--- a/content/browser/media/session/media_session_impl.cc

+++ b/content/browser/media/session/media_session_impl.cc

@@ -95,6 +95,8 @@ MediaSessionImpl::~MediaSessionImpl() {

DCHECK(audio_focus_state_ == State::INACTIVE);

for (auto& observer : observers_)

observer.MediaSessionDestroyed();

+ for (auto& observer : observers_)

+ observer.StopObserving();

derekjchow 2017/03/29 00:50:17 Probably makes sense to fuse the two for loops.

seantopping 2017/03/29 00:56:40 Done.

}

void MediaSessionImpl::WebContentsDestroyed() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »