Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1034)

Unified Diff: content/browser/download/download_file_unittest.cc

Issue 2782033002: remove is_sparse_file_ from DownloadFileImpl (Closed)
Patch Set: add IsSparseFile() helper method Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_file_unittest.cc
diff --git a/content/browser/download/download_file_unittest.cc b/content/browser/download/download_file_unittest.cc
index 5435db3f0dcdc550978827ffc805a24b5d16f038..99ae97d445972d2af39ff776c2b70501887a93eb 100644
--- a/content/browser/download/download_file_unittest.cc
+++ b/content/browser/download/download_file_unittest.cc
@@ -124,14 +124,12 @@ class TestDownloadFileImpl : public DownloadFileImpl {
std::unique_ptr<ByteStreamReader> stream,
const std::vector<DownloadItem::ReceivedSlice>& received_slices,
const net::NetLogWithSource& net_log,
- bool is_sparse_file,
base::WeakPtr<DownloadDestinationObserver> observer)
: DownloadFileImpl(std::move(save_info),
default_downloads_directory,
std::move(stream),
received_slices,
net_log,
- is_sparse_file,
observer) {}
protected:
@@ -208,14 +206,13 @@ class DownloadFileTest : public testing::Test {
}
bool CreateDownloadFile(int offset, bool calculate_hash) {
- return CreateDownloadFile(offset, 0, calculate_hash, false,
+ return CreateDownloadFile(offset, 0, calculate_hash,
DownloadItem::ReceivedSlices());
}
bool CreateDownloadFile(int offset,
int length,
bool calculate_hash,
- bool is_sparse_file,
const DownloadItem::ReceivedSlices& received_slices) {
// There can be only one.
DCHECK(!download_file_.get());
@@ -235,8 +232,7 @@ class DownloadFileTest : public testing::Test {
download_file_.reset(new TestDownloadFileImpl(
std::move(save_info), base::FilePath(),
std::unique_ptr<ByteStreamReader>(input_stream_), received_slices,
- net::NetLogWithSource(), is_sparse_file,
- observer_factory_.GetWeakPtr()));
+ net::NetLogWithSource(), observer_factory_.GetWeakPtr()));
EXPECT_CALL(*input_stream_, Read(_, _))
.WillOnce(Return(ByteStreamReader::STREAM_EMPTY))
@@ -910,7 +906,7 @@ TEST_F(DownloadFileTest, MutipleStreamsWrite) {
int64_t stream_0_length = GetBuffersLength(kTestData6, 2);
int64_t stream_1_length = GetBuffersLength(kTestData7, 2);
- ASSERT_TRUE(CreateDownloadFile(0, stream_0_length, true, true,
+ ASSERT_TRUE(CreateDownloadFile(0, stream_0_length, true,
DownloadItem::ReceivedSlices()));
PrepareStream(&input_stream_, 0, false, true, kTestData6, 2);
@@ -949,7 +945,7 @@ TEST_F(DownloadFileTest, MutipleStreamsLimitedLength) {
// "Range:50-".
int64_t stream_2_length = GetBuffersLength(kTestData6, 2);
- ASSERT_TRUE(CreateDownloadFile(0, stream_0_length, true, true,
+ ASSERT_TRUE(CreateDownloadFile(0, stream_0_length, true,
DownloadItem::ReceivedSlices()));
PrepareStream(&input_stream_, 0, false, true, kTestData6, 2);
@@ -998,7 +994,7 @@ TEST_F(DownloadFileTest, MutipleStreamsFirstStreamWriteAllData) {
int64_t stream_0_length = GetBuffersLength(kTestData8, 4);
ASSERT_TRUE(CreateDownloadFile(0, DownloadSaveInfo::kLengthFullContent, true,
- true, DownloadItem::ReceivedSlices()));
+ DownloadItem::ReceivedSlices()));
PrepareStream(&input_stream_, 0, false, true, kTestData8, 4);

Powered by Google App Engine
This is Rietveld 408576698