remove is_sparse_file_ from DownloadFileImpl

content/browser/download/download_file_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_FILE_IMPL_H_
 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_FILE_IMPL_H_
 
 #include "content/browser/download/download_file.h"
 
 #include <stddef.h>
@@ skipping 31 matching lines @@
   //
   // Note that the DownloadFileImpl automatically reads from the passed in
   // stream, and sends updates and status of those reads to the
   // DownloadDestinationObserver.
   DownloadFileImpl(
       std::unique_ptr<DownloadSaveInfo> save_info,
       const base::FilePath& default_downloads_directory,
       std::unique_ptr<ByteStreamReader> stream_reader,
       const std::vector<DownloadItem::ReceivedSlice>& received_slices,
       const net::NetLogWithSource& net_log,
-      bool is_sparse_file,
       base::WeakPtr<DownloadDestinationObserver> observer);
 
   ~DownloadFileImpl() override;
 
   // DownloadFile functions.
   void Initialize(const InitializeCallback& callback) override;
 
   void AddByteStream(std::unique_ptr<ByteStreamReader> stream_reader,
                      int64_t offset,
                      int64_t length) override;
@@ skipping 152 matching lines @@
 
   // Return the total valid bytes received in the target file.
   // If the file is a sparse file, return the total number of valid bytes.
   // Otherwise, return the current file size.
   int64_t TotalBytesReceived() const;
 
   // Helper method to handle stream error
   void HandleStreamError(SourceStream* source_stream,
                          DownloadInterruptReason reason);
 
+  // Check whether this file is potentially sparse.
+  bool IsSparseFile() const;
+
   // Given a SourceStream object, returns its neighbor that preceds it if
   // SourceStreams are ordered by their offsets
   SourceStream* FindPrecedingNeighbor(SourceStream* source_stream);
 
   // Print the internal states for debugging.
   void DebugStates() const;
 
   net::NetLogWithSource net_log_;
 
   // The base file instance.
   BaseFile file_;
 
   // DownloadSaveInfo provided during construction. Since the DownloadFileImpl
   // can be created on any thread, this holds the save_info_ until it can be
   // used to initialize file_ on the FILE thread.
   std::unique_ptr<DownloadSaveInfo> save_info_;
 
   // The default directory for creating the download file.
   base::FilePath default_download_directory_;
 
   // Map of the offset and the source stream that represents the slice
   // starting from offset.
   SourceStreams source_streams_;
 
   // Used to trigger progress updates.
   std::unique_ptr<base::RepeatingTimer> update_timer_;
 
-  // Set to true when multiple byte streams write to the same file.
-  // The file may contain null bytes(holes) in between of valid data slices.
-  // TODO(xingliu): Remove this variable. We can use size of |received_slices_|
-  // to determine if the file is sparse
-  bool is_sparse_file_;
-
   // Statistics
   size_t bytes_seen_;
   base::TimeDelta disk_writes_time_;
   base::TimeTicks download_start_;
   RateEstimator rate_estimator_;
   int num_active_streams_;
   bool record_stream_bandwidth_;
   base::TimeTicks last_update_time_;
   size_t bytes_seen_with_parallel_streams_;
   size_t bytes_seen_without_parallel_streams_;
   base::TimeDelta download_time_with_parallel_streams_;
   base::TimeDelta download_time_without_parallel_streams_;
 
   std::vector<DownloadItem::ReceivedSlice> received_slices_;
 
   base::WeakPtr<DownloadDestinationObserver> observer_;
   base::WeakPtrFactory<DownloadFileImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(DownloadFileImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_FILE_IMPL_H_