remove is_sparse_file_ from DownloadFileImpl

content/browser/download/download_file_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <utility>
 #include <vector>
 
@@ skipping 106 matching lines @@
 // This is a test DownloadFileImpl that has no retry delay and, on Posix,
 // retries renames failed due to ACCESS_DENIED.
 class TestDownloadFileImpl : public DownloadFileImpl {
  public:
   TestDownloadFileImpl(
       std::unique_ptr<DownloadSaveInfo> save_info,
       const base::FilePath& default_downloads_directory,
       std::unique_ptr<ByteStreamReader> stream,
       const std::vector<DownloadItem::ReceivedSlice>& received_slices,
       const net::NetLogWithSource& net_log,
-      bool is_sparse_file,
       base::WeakPtr<DownloadDestinationObserver> observer)
       : DownloadFileImpl(std::move(save_info),
                          default_downloads_directory,
                          std::move(stream),
                          received_slices,
                          net_log,
-                         is_sparse_file,
                          observer) {}
 
  protected:
   base::TimeDelta GetRetryDelayForFailedRename(int attempt_count) override {
     return base::TimeDelta::FromMilliseconds(0);
   }
 
 #if !defined(OS_WIN)
   // On Posix, we don't encounter transient errors during renames, except
   // possibly EAGAIN, which is difficult to replicate reliably. So we resort to
@@ skipping 56 matching lines @@
   }
 
   void SetInterruptReasonCallback(const base::Closure& closure,
                                   DownloadInterruptReason* reason_p,
                                   DownloadInterruptReason reason) {
     *reason_p = reason;
     closure.Run();
   }
 
   bool CreateDownloadFile(int offset, bool calculate_hash) {
-    return CreateDownloadFile(offset, 0, calculate_hash, false,
+    return CreateDownloadFile(offset, 0, calculate_hash,
                               DownloadItem::ReceivedSlices());
   }
 
   bool CreateDownloadFile(int offset,
                           int length,
                           bool calculate_hash,
-                          bool is_sparse_file,
                           const DownloadItem::ReceivedSlices& received_slices) {
     // There can be only one.
     DCHECK(!download_file_.get());
 
     input_stream_ = new StrictMock<MockByteStreamReader>();
 
     // TODO: Need to actually create a function that'll set the variables
     // based on the inputs from the callback.
     EXPECT_CALL(*input_stream_, RegisterCallback(_))
         .WillOnce(Invoke(this, &DownloadFileTest::RegisterCallback))
         .RetiresOnSaturation();
 
     std::unique_ptr<DownloadSaveInfo> save_info(new DownloadSaveInfo());
     save_info->offset = offset;
     save_info->length = length;
 
     download_file_.reset(new TestDownloadFileImpl(
         std::move(save_info), base::FilePath(),
         std::unique_ptr<ByteStreamReader>(input_stream_), received_slices,
-        net::NetLogWithSource(), is_sparse_file,
-        observer_factory_.GetWeakPtr()));
+        net::NetLogWithSource(), observer_factory_.GetWeakPtr()));
 
     EXPECT_CALL(*input_stream_, Read(_, _))
         .WillOnce(Return(ByteStreamReader::STREAM_EMPTY))
         .RetiresOnSaturation();
 
     base::WeakPtrFactory<DownloadFileTest> weak_ptr_factory(this);
     DownloadInterruptReason result = DOWNLOAD_INTERRUPT_REASON_NONE;
     base::RunLoop loop_runner;
     download_file_->Initialize(base::Bind(
         &DownloadFileTest::SetInterruptReasonCallback,
@@ skipping 653 matching lines @@
   DestroyDownloadFile(0);
 }
 
 // Tests for concurrent streams handling, used for parallel download.
 //
 // Activate both streams at the same time.
 TEST_F(DownloadFileTest, MutipleStreamsWrite) {
   int64_t stream_0_length = GetBuffersLength(kTestData6, 2);
   int64_t stream_1_length = GetBuffersLength(kTestData7, 2);
 
-  ASSERT_TRUE(CreateDownloadFile(0, stream_0_length, true, true,
+  ASSERT_TRUE(CreateDownloadFile(0, stream_0_length, true,
                                  DownloadItem::ReceivedSlices()));
 
   PrepareStream(&input_stream_, 0, false, true, kTestData6, 2);
   PrepareStream(&additional_streams_[0], stream_0_length, true, true,
                 kTestData7, 2);
 
   EXPECT_CALL(*additional_streams_[0], RegisterCallback(_))
       .RetiresOnSaturation();
   EXPECT_CALL(*(observer_.get()), MockDestinationCompleted(_, _));
 
@@ skipping 18 matching lines @@
   int64_t stream_0_length = GetBuffersLength(kTestData6, 2);
 
   // The second stream has a limited length and should be partially written
   // to disk. When we prepare the stream, we fill the stream with 2 full buffer.
   int64_t stream_1_length = GetBuffersLength(kTestData7, 2) - 1;
 
   // The last stream can't have length limit, it's a half open request, e.g
   // "Range:50-".
   int64_t stream_2_length = GetBuffersLength(kTestData6, 2);
 
-  ASSERT_TRUE(CreateDownloadFile(0, stream_0_length, true, true,
+  ASSERT_TRUE(CreateDownloadFile(0, stream_0_length, true,
                                  DownloadItem::ReceivedSlices()));
 
   PrepareStream(&input_stream_, 0, false, true, kTestData6, 2);
   PrepareStream(&additional_streams_[0], stream_0_length, true, false,
                 kTestData7, 2);
   PrepareStream(&additional_streams_[1], stream_0_length + stream_1_length,
                 true, true, kTestData6, 2);
 
   EXPECT_CALL(*additional_streams_[0], RegisterCallback(_))
       .Times(2)
@@ skipping 28 matching lines @@
 
   download_file_->Cancel();
   DestroyDownloadFile(0, false);
 }
 
 //  Activate and deplete one stream, later add the second stream.
 TEST_F(DownloadFileTest, MutipleStreamsFirstStreamWriteAllData) {
   int64_t stream_0_length = GetBuffersLength(kTestData8, 4);
 
   ASSERT_TRUE(CreateDownloadFile(0, DownloadSaveInfo::kLengthFullContent, true,
-                                 true, DownloadItem::ReceivedSlices()));
+                                 DownloadItem::ReceivedSlices()));
 
   PrepareStream(&input_stream_, 0, false, true, kTestData8, 4);
 
   EXPECT_CALL(*(observer_.get()), MockDestinationCompleted(_, _));
 
   sink_callback_.Run();
   base::RunLoop().RunUntilIdle();
 
   // Add another stream, the file is already closed, so nothing should be
   // called.
   EXPECT_FALSE(download_file_->InProgress());
 
   additional_streams_[0] = new StrictMock<MockByteStreamReader>();
   download_file_->AddByteStream(
       std::unique_ptr<MockByteStreamReader>(additional_streams_[0]),
       stream_0_length - 1, DownloadSaveInfo::kLengthFullContent);
   base::RunLoop().RunUntilIdle();
 
   SourceStreamTestData stream_data_0(0, stream_0_length, true);
   SourceStreamTestData stream_data_1(stream_0_length - 1, 0, false);
   VerifySourceStreamsStates(stream_data_0);
   VerifySourceStreamsStates(stream_data_1);
   EXPECT_EQ(stream_0_length, TotalBytesReceived());
 
   DestroyDownloadFile(0);
 }
 
 }  // namespace content