Protect SerializedData from copying.

src/snapshot/serializer-common.h

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_SNAPSHOT_SERIALIZER_COMMON_H_
 #define V8_SNAPSHOT_SERIALIZER_COMMON_H_
 
 #include "src/address-map.h"
 #include "src/external-reference-table.h"
 #include "src/globals.h"
@@ skipping 221 matching lines @@
 
     void mark_as_last() { reservation_ |= IsLastChunkBits::encode(true); }
 
    private:
     uint32_t reservation_;
   };
 
   SerializedData(byte* data, int size)
       : data_(data), size_(size), owns_data_(false) {}
   SerializedData() : data_(NULL), size_(0), owns_data_(false) {}
+  SerializedData(SerializedData&& other)
+      : data_(other.data_), size_(other.size_), owns_data_(other.owns_data_) {
+    // Ensure |other| will not attempt to destroy our data in destructor.
+    other.owns_data_ = false;
+  }
 
   ~SerializedData() {
     if (owns_data_) DeleteArray<byte>(data_);
   }
 
+  SerializedData(const SerializedData&) = delete;
+  const SerializedData& operator=(const SerializedData&) = delete;
+

[Yang, 2017/03/29 17:06:59]

We have a macro called DISALLOW_COPY_AND_ASSIGN or similar for this.

[Slava Chigrin, 2017/03/30 09:40:06]

Done. Thanks - didn't notice that V8 also have this macro.

   uint32_t GetMagicNumber() const { return GetHeaderValue(kMagicNumberOffset); }
   uint32_t GetExtraReferences() const {
     return GetHeaderValue(kExtraExternalReferencesOffset);
   }
 
   class ChunkSizeBits : public BitField<uint32_t, 0, 31> {};
   class IsLastChunkBits : public BitField<bool, 31, 1> {};
 
   static uint32_t ComputeMagicNumber(ExternalReferenceTable* table) {
     uint32_t external_refs = table->size() - table->num_api_references();
@@ skipping 37 matching lines @@
 
   byte* data_;
   int size_;
   bool owns_data_;
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_SNAPSHOT_SERIALIZER_COMMON_H_