Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2594)

Unified Diff: content/test/gpu/gpu_tests/gpu_process_integration_test.py

Issue 2781993002: Get the proper GPU Info in GpuProcessHost (Closed)
Patch Set: Added tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/gpu/gpu_process_host.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/gpu/gpu_tests/gpu_process_integration_test.py
diff --git a/content/test/gpu/gpu_tests/gpu_process_integration_test.py b/content/test/gpu/gpu_tests/gpu_process_integration_test.py
index 247c952bbcce125a8ae7c2109bbf2e28949117e3..bb144a4ecd653414d95a0fca5ca916012c82f069 100644
--- a/content/test/gpu/gpu_tests/gpu_process_integration_test.py
+++ b/content/test/gpu/gpu_tests/gpu_process_integration_test.py
@@ -549,6 +549,22 @@ class GpuProcessIntegrationTest(gpu_integration_test.GpuIntegrationTest):
self.fail('getParameter(UNMASKED_RENDERER_WEBGL) was null')
if 'SwiftShader' not in renderer:
self.fail('Expected SwiftShader renderer; instead got ' + renderer)
+ if not self.browser.supports_system_info:
+ self.fail("Browser doesn't support GetSystemInfo")
+ gpu = self.browser.GetSystemInfo().gpu
+ if not gpu:
+ self.fail('Target machine must have a GPU')
+ if not gpu.aux_attributes:
+ self.fail('Browser must support GPU aux attributes')
+ if not gpu.aux_attributes['software_rendering']:
+ self.fail("Software rendering was disabled")
+ device = gpu.devices[0]
+ if not device:
+ self.fail("System Info doesn't have a device")
+ if device.vendor_id != 0:
+ self.fail("Wrong vendor ID. Expected 0, got " + hex(device.vendor_id))
+ if device.device_id != 0:
+ self.fail("Wrong device ID. Expected 0, got " + hex(device.device_id))
Ken Russell (switch to Gerrit) 2017/03/31 22:47:11 Great. Did these new parts fail without your patch
sugoi1 2017/04/01 02:05:40 Yes, locally, vendor_id and device_id tests failed
def load_tests(loader, tests, pattern):
del loader, tests, pattern # Unused.
« no previous file with comments | « content/browser/gpu/gpu_process_host.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698