Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2781963002: Fix for Quick Fix to import SDK classes. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for Quick Fix to import SDK classes. It's not 100% replacement, we handle SDK libraries just as any other library, if it has not been imported yet somewhere, we don't know about it. But probably this covers the most often case of using a library in a new file of the project that already uses this SDK library. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/483066a6971b1cdd0485370683d58cab73f1159b

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -103 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 3 chunks +4 lines, -42 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 1 chunk +0 lines, -61 lines 0 comments Download
M pkg/front_end/front_end.iml View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-03-28 20:17:39 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2781963002/diff/1/pkg/front_end/front_end.iml File pkg/front_end/front_end.iml (right): https://codereview.chromium.org/2781963002/diff/1/pkg/front_end/front_end.iml#newcode23 pkg/front_end/front_end.iml:23: <orderEntry type="library" name="Dart Packages" level="project" /> Did you ...
3 years, 8 months ago (2017-03-28 21:11:22 UTC) #2
scheglov
3 years, 8 months ago (2017-03-28 21:16:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
483066a6971b1cdd0485370683d58cab73f1159b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698