Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: runtime/vm/kernel_to_il.h

Issue 2781893004: Remove definitions from Kernel canonical names. (Closed)
Patch Set: Update test expectations. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/kernel_reader.cc ('k') | runtime/vm/kernel_to_il.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/kernel_to_il.h
diff --git a/runtime/vm/kernel_to_il.h b/runtime/vm/kernel_to_il.h
index 1a58d4f83081255be3ac149bc0e22788f0cd7616..9dd05e60263b2582f55c320b138478d116be6367 100644
--- a/runtime/vm/kernel_to_il.h
+++ b/runtime/vm/kernel_to_il.h
@@ -301,16 +301,26 @@ class TranslationHelper {
const dart::String& DartSymbol(const char* content) const;
dart::String& DartSymbol(String* content) const;
- const dart::String& DartClassName(CanonicalName* kernel_klass);
- const dart::String& DartConstructorName(Constructor* node);
- const dart::String& DartProcedureName(Procedure* procedure);
+ const dart::String& DartClassName(CanonicalName* kernel_class);
+
+ const dart::String& DartConstructorName(CanonicalName* constructor);
+
+ const dart::String& DartProcedureName(CanonicalName* procedure);
+
+ const dart::String& DartSetterName(CanonicalName* setter);
+ const dart::String& DartSetterName(Name* setter_name);
+
+ const dart::String& DartGetterName(CanonicalName* getter);
+ const dart::String& DartGetterName(Name* getter_name);
- const dart::String& DartSetterName(Name* kernel_name);
- const dart::String& DartGetterName(Name* kernel_name);
const dart::String& DartFieldName(Name* kernel_name);
+
const dart::String& DartInitializerName(Name* kernel_name);
- const dart::String& DartMethodName(Name* kernel_name);
- const dart::String& DartFactoryName(Class* klass, Name* kernel_name);
+
+ const dart::String& DartMethodName(CanonicalName* method);
+ const dart::String& DartMethodName(Name* method_name);
+
+ const dart::String& DartFactoryName(CanonicalName* factory);
const Array& ArgumentNames(List<NamedExpression>* named);
@@ -320,12 +330,12 @@ class TranslationHelper {
virtual RawLibrary* LookupLibraryByKernelLibrary(CanonicalName* library);
virtual RawClass* LookupClassByKernelClass(CanonicalName* klass);
- RawField* LookupFieldByKernelField(Field* field);
- RawFunction* LookupStaticMethodByKernelProcedure(Procedure* procedure);
- RawFunction* LookupConstructorByKernelConstructor(Constructor* constructor);
+ RawField* LookupFieldByKernelField(CanonicalName* field);
+ RawFunction* LookupStaticMethodByKernelProcedure(CanonicalName* procedure);
+ RawFunction* LookupConstructorByKernelConstructor(CanonicalName* constructor);
dart::RawFunction* LookupConstructorByKernelConstructor(
const dart::Class& owner,
- Constructor* constructor);
+ CanonicalName* constructor);
dart::Type& GetCanonicalType(const dart::Class& klass);
@@ -333,12 +343,18 @@ class TranslationHelper {
void ReportError(const Error& prev_error, const char* format, ...);
private:
- // This will mangle [kernel_name] (if necessary) and make the result a symbol.
- // The result will be avilable in [name_to_modify] and it is also returned.
- dart::String& ManglePrivateName(CanonicalName* kernel_library,
+ // This will mangle [name_to_modify] if necessary and make the result a symbol
+ // if asked. The result will be avilable in [name_to_modify] and it is also
+ // returned. If the name is private, the canonical name [parent] will be used
+ // to get the import URI of the library where the name is visible.
+ dart::String& ManglePrivateName(CanonicalName* parent,
dart::String* name_to_modify,
bool symbolize = true);
+ const dart::String& DartSetterName(CanonicalName* parent, String* setter);
+ const dart::String& DartGetterName(CanonicalName* parent, String* getter);
+ const dart::String& DartMethodName(CanonicalName* parent, String* method);
+
dart::Thread* thread_;
dart::Zone* zone_;
dart::Isolate* isolate_;
@@ -817,7 +833,7 @@ class FlowGraphBuilder : public ExpressionVisitor, public StatementVisitor {
Fragment TranslateArguments(Arguments* node, Array* argument_names);
ArgumentArray GetArguments(int count);
- Fragment TranslateInitializers(Class* kernel_klass,
+ Fragment TranslateInitializers(Class* kernel_class,
List<Initializer>* initialiers);
Fragment TranslateStatement(Statement* statement);
@@ -944,7 +960,7 @@ class FlowGraphBuilder : public ExpressionVisitor, public StatementVisitor {
bool NeedsDebugStepCheck(Value* value, TokenPosition position);
Fragment DebugStepCheck(TokenPosition position);
- dart::RawFunction* LookupMethodByMember(Member* target,
+ dart::RawFunction* LookupMethodByMember(CanonicalName* target,
const dart::String& method_name);
LocalVariable* MakeTemporary();
« no previous file with comments | « runtime/vm/kernel_reader.cc ('k') | runtime/vm/kernel_to_il.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698