[inspector] prepared console before moving into builtins

src/inspector/v8-console.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/inspector/v8-console.h"
 
 #include "src/base/macros.h"
 #include "src/inspector/injected-script.h"
 #include "src/inspector/inspected-context.h"
 #include "src/inspector/string-util.h"
@@ skipping 539 matching lines @@
     V8InspectorSession::Inspectable* object = session->inspectedObject(num);
     v8::Isolate* isolate = info.GetIsolate();
     if (object)
       info.GetReturnValue().Set(object->get(isolate->GetCurrentContext()));
     else
       info.GetReturnValue().Set(v8::Undefined(isolate));
   }
 }
 
 v8::Local<v8::Object> V8Console::createConsole(
-    InspectedContext* inspectedContext, bool hasMemoryAttribute) {
+    InspectedContext* inspectedContext) {
   v8::Local<v8::Context> context = inspectedContext->context();
   v8::Context::Scope contextScope(context);
   v8::Isolate* isolate = context->GetIsolate();
   v8::MicrotasksScope microtasksScope(isolate,
                                       v8::MicrotasksScope::kDoNotRunMicrotasks);
 
   v8::Local<v8::Object> console = v8::Object::New(isolate);
   bool success =
       console->SetPrototype(context, v8::Object::New(isolate)).FromMaybe(false);
   DCHECK(success);
@@ skipping 40 matching lines @@
   createBoundFunctionProperty(context, console, data, "timeline",
                               V8Console::timelineCallback);
   createBoundFunctionProperty(context, console, data, "timelineEnd",
                               V8Console::timelineEndCallback);
   createBoundFunctionProperty(context, console, data, "time",
                               V8Console::timeCallback);
   createBoundFunctionProperty(context, console, data, "timeEnd",
                               V8Console::timeEndCallback);
   createBoundFunctionProperty(context, console, data, "timeStamp",
                               V8Console::timeStampCallback);
+  return console;
+}
 
-  const char* jsConsoleAssert =
-      "(function(){\n"
-      "  var originAssert = this.assert;\n"
-      "  originAssert.apply = Function.prototype.apply;\n"
-      "  this.assert = assertWrapper;\n"
-      "  assertWrapper.toString = () => originAssert.toString();\n"
-      "  function assertWrapper(){\n"
-      "    if (!!arguments[0]) return;\n"
-      "    originAssert.apply(null, arguments);\n"
-      "  }\n"
-      "})";
-
-  v8::Local<v8::String> assertSource = toV8String(isolate, jsConsoleAssert);
-  V8InspectorImpl* inspector = inspectedContext->inspector();
-  v8::Local<v8::Value> setupFunction;
-  if (inspector->compileAndRunInternalScript(context, assertSource)
-          .ToLocal(&setupFunction) &&
-      setupFunction->IsFunction()) {
-    v8::MicrotasksScope microtasksScope(
-        isolate, v8::MicrotasksScope::kDoNotRunMicrotasks);
-    v8::MaybeLocal<v8::Value> result;
-    result = v8::Local<v8::Function>::Cast(setupFunction)
-                 ->Call(context, console, 0, nullptr);
-  }
-
-  if (hasMemoryAttribute) {
-    console->SetAccessorProperty(
-        toV8StringInternalized(isolate, "memory"),
-        v8::Function::New(context, V8Console::memoryGetterCallback, data, 0,
-                          v8::ConstructorBehavior::kThrow)
-            .ToLocalChecked(),
-        v8::Function::New(context, V8Console::memorySetterCallback, data, 0,
-                          v8::ConstructorBehavior::kThrow)
-            .ToLocalChecked(),
-        static_cast<v8::PropertyAttribute>(v8::None), v8::DEFAULT);
-  }
-
-  return console;
+void V8Console::installMemoryGetter(V8InspectorImpl* inspector,
+                                    v8::Local<v8::Context> context,
+                                    v8::Local<v8::Object> console) {
+  v8::Local<v8::External> data =
+      v8::External::New(inspector->isolate(), inspector);
+  console->SetAccessorProperty(
+      toV8StringInternalized(inspector->isolate(), "memory"),
+      v8::Function::New(context, V8Console::memoryGetterCallback, data, 0,
+                        v8::ConstructorBehavior::kThrow)
+          .ToLocalChecked(),
+      v8::Function::New(context, V8Console::memorySetterCallback, data, 0,
+                        v8::ConstructorBehavior::kThrow)
+          .ToLocalChecked(),
+      static_cast<v8::PropertyAttribute>(v8::None), v8::DEFAULT);
 }
 
 v8::Local<v8::Object> V8Console::createCommandLineAPI(
     InspectedContext* inspectedContext) {
   v8::Local<v8::Context> context = inspectedContext->context();
   v8::Isolate* isolate = context->GetIsolate();
   v8::MicrotasksScope microtasksScope(isolate,
                                       v8::MicrotasksScope::kDoNotRunMicrotasks);
 
   v8::Local<v8::Object> commandLineAPI = v8::Object::New(isolate);
@@ skipping 165 matching lines @@
                          ->GetOwnPropertyDescriptor(
                              m_context, v8::Local<v8::String>::Cast(name))
                          .ToLocal(&descriptor);
       DCHECK(success);
       USE(success);
     }
   }
 }
 
 }  // namespace v8_inspector