Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerClipper.h

Issue 2781863005: Account for filter bounds for backgroundRect during PaintLayer painting (Closed)
Patch Set: none Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayerClipper.h
diff --git a/third_party/WebKit/Source/core/paint/PaintLayerClipper.h b/third_party/WebKit/Source/core/paint/PaintLayerClipper.h
index ddfc612bcffbf64b41f554ab2e654c15239ce4ec..afecdc963302cf9cddae52fe03bea95acf78895f 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayerClipper.h
+++ b/third_party/WebKit/Source/core/paint/PaintLayerClipper.h
@@ -216,14 +216,18 @@ class CORE_EXPORT PaintLayerClipper {
ALWAYS_INLINE bool shouldRespectOverflowClip(const ClipRectsContext&) const;
// Returned clip rect in |output| is in the space of the context's rootLayer.
- ALWAYS_INLINE void calculateClipRectWithGeometryMapper(
+ ALWAYS_INLINE void calculateBackgroundClipRectWithGeometryMapper(
const ClipRectsContext&,
- bool isForeground,
ClipRect& output) const;
- // Mutates the given rect into a rect in the space of the context's
- // rootLayer.
- ALWAYS_INLINE void mapLocalToRootWithGeometryMapper(const ClipRectsContext&,
- LayoutRect&) const;
+ ALWAYS_INLINE void calculateForegroundClipRectWithGeometryMapper(
+ const ClipRectsContext&,
+ ClipRect& output) const;
+
+ ALWAYS_INLINE void initializeCommonClipRectState(
+ const ClipRectsContext&,
+ PropertyTreeState& descendantPropertyTreeState,
+ PropertyTreeState& ancestorPropertyTreeState) const;
+
// Same as calculateRects, but using GeometryMapper.
ALWAYS_INLINE void calculateRectsWithGeometryMapper(
const ClipRectsContext&,
@@ -233,9 +237,9 @@ class CORE_EXPORT PaintLayerClipper {
ClipRect& foregroundRect,
const LayoutPoint* offsetFromRoot = 0) const;
- void ALWAYS_INLINE
- applyOverflowClipToBackgroundRectWithGeometryMapper(const ClipRectsContext&,
- ClipRect&) const;
+ // Returns the visual rect of m_layer in local space. This includes
+ // filter effects.
+ ALWAYS_INLINE LayoutRect localVisualRect() const;
const PaintLayer& m_layer;
GeometryMapper* m_geometryMapper;

Powered by Google App Engine
This is Rietveld 408576698