Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py

Issue 2781733003: Improve run-webkit-tests error reporting when ref tests have missing images. (Closed)
Patch Set: review comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py
index 1fdb9f1d97b8116f8598b46cd11b56043e60866e..14c40f513ec286cc1a3fc4b4bcc17e2962008946 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py
@@ -79,6 +79,19 @@ class TestResultWriterTests(unittest.TestCase):
written_files = self.run_test(failures=[failure], files={})
self.assertEqual(written_files, {})
+ def test_reftest_image_missing(self):
+ failure = test_failures.FailureReftestNoImageGenerated()
+ failure.reference_filename = '/src/exists-expected.html'
+ files = {'/src/exists-expected.html': 'yup'}
+ written_files = self.run_test(failures=[failure], files=files)
+ self.assertEqual(written_files, {'/tmp/exists-expected.html': 'yup'})
+
+ failure = test_failures.FailureReftestNoReferenceImageGenerated()
+ failure.reference_filename = '/src/exists-expected.html'
+ files = {'/src/exists-expected.html': 'yup'}
+ written_files = self.run_test(failures=[failure], files=files)
+ self.assertEqual(written_files, {'/tmp/exists-expected.html': 'yup'})
+
def test_baseline_name(self):
fs = MockFileSystem()
self.assertEqual(baseline_name(fs, 'x/y/foo.html', 'txt'), 'x/y/foo-expected.txt')

Powered by Google App Engine
This is Rietveld 408576698